All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Friesen <chris.friesen@genband.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: "Ric Wheeler" <rwheeler@redhat.com>,
	"Mathias Burén" <mathias.buren@gmail.com>,
	"Roy Sigurd Karlsbakk" <roy@karlsbakk.net>,
	"Neil Brown" <neilb@suse.de>,
	Linux-RAID <linux-raid@vger.kernel.org>,
	"Jens Axboe" <axboe@kernel.dk>,
	"IDE/ATA development list" <linux-ide@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: getting I/O errors in super_written()...any ideas what would cause this?
Date: Thu, 06 Dec 2012 12:15:32 -0600	[thread overview]
Message-ID: <50C0E0C4.9050400@genband.com> (raw)
In-Reply-To: <1354699254.2243.5.camel@dabdike.int.hansenpartnership.com>

On 12/05/2012 03:20 AM, James Bottomley wrote:
> On Tue, 2012-12-04 at 16:00 -0600, Chris Friesen wrote:
>> As another data point, it looks like we may be doing a SEND DIAGNOSTIC
>> command specifying the default self-test in addition to the background
>> short self-test.  This seems a bit risky and excessive to me, but
>> apparently the guy that wrote it is no longer with the company.
>
> This is a really bad idea.  A lot of disks go out to lunch until the
> diagnostics complete (the same goes for SMART diagnostics).  This means
> that if you do diagnostics on a running device, the drivers start to get
> timeouts on commands which are queued waiting for diagnostics to
> complete ... if those go over the standard SCSI timeouts, we'll start to
> try error recovery and likely have the disaster you see above.

So it turns out that our problems are intermittently triggered when 
running the default self test.  This agrees with the statement in 
sg_senddiag to not do foreground self-tests on disks with mounted 
filesystems.

We seem to be able to do background short self-tests (ie, SEND 
DIAGNOSTIC command with self-test code of 001b and ST code of 0b) 
without causing any problems.  Is this pushing our luck or is this 
something that should work according to the spec and the linux stack? 
The scsi spec indicates that in this case for most commands the test 
will be paused and the command executed within 2 seconds, but I don't 
know what the normal scsi timeouts are.

Thanks for the input, this is very useful.

Chris

  parent reply	other threads:[~2012-12-06 18:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 17:52 getting I/O errors in super_written()...any ideas what would cause this? Chris Friesen
2012-11-28 18:08 ` Mathias Burén
2012-11-28 18:51   ` Roy Sigurd Karlsbakk
2012-11-28 20:21     ` Chris Friesen
2012-11-28 20:27       ` Mathias Burén
2012-11-28 20:29         ` Chris Friesen
2012-12-03 20:22           ` Ric Wheeler
2012-12-03 20:44             ` Chris Friesen
2012-12-03 20:52               ` Ric Wheeler
2012-12-03 21:08                 ` Chris Friesen
2012-12-03 21:21                   ` Dave Jiang
2012-12-03 21:36                     ` Chris Friesen
2012-12-03 21:59                       ` Dave Jiang
2012-12-03 21:53                   ` Ric Wheeler
2012-12-04 22:00                     ` Chris Friesen
2012-12-04 23:55                       ` Ric Wheeler
2012-12-05  9:20                       ` James Bottomley
2012-12-05 11:41                         ` Ric Wheeler
2012-12-05 11:57                           ` James Bottomley
2012-12-06 18:15                         ` Chris Friesen [this message]
2012-12-06 20:27                           ` Chris Murphy
2012-12-08 18:08                           ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C0E0C4.9050400@genband.com \
    --to=chris.friesen@genband.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=axboe@kernel.dk \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mathias.buren@gmail.com \
    --cc=neilb@suse.de \
    --cc=roy@karlsbakk.net \
    --cc=rwheeler@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.