All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Hernandez <ceh@ti.com>
To: Denys Dmytriyenko <denys@ti.com>
Cc: "meta-arago@arago-project.org" <meta-arago@arago-project.org>,
	"Cooper Jr., Franklin" <fcooper@ti.com>
Subject: Re: [PATCH v2] Define arago-test-image
Date: Thu, 6 Dec 2012 17:23:25 -0500	[thread overview]
Message-ID: <50C11ADD.5010803@ti.com> (raw)
In-Reply-To: <20121206203356.GD17596@denix.org>

[-- Attachment #1: Type: text/plain, Size: 2447 bytes --]

Please find v2 attached.

Thanks,
Carlos
On 12/06/2012 03:33 PM, Denys Dmytriyenko wrote:
> On Thu, Dec 06, 2012 at 03:28:19PM -0500, Carlos Hernandez wrote:
>> Franklin,
>>
>> That's a fair point. I did it to keep some independence between the
>> arago-test and arago-tisdk images but I'm OK including
>> task-arago-tisdk-addons instead of task-arago-test-addons. I guess we
>> could separate into different task files only if needed in the future.
>>
>> One task that will need to be added to task-arago-tisdk-addons is
>> bridge-utils.
>> bridge-utils is currently only included by task-arago-test-addons.
>>
>> Let me know if you are OK adding bridge-utils and I can submit another
>> patch with these changes.
> You could also add bridge-utils to your task-arago-test recipe.
>
> Or, you could just add bridge-utils besides the regular task-arago-tisdk-addons 
> to IMAGE_INSTALL in your test image recipe:
>
> IMAGE_INSTALL += "\
>     task-arago-base \
>     task-arago-console \
>     task-arago-base-tisdk \
>     task-arago-tisdk-connectivity \
>     task-arago-tisdk-crypto \
>     task-arago-tisdk-multimedia \
>     task-arago-tisdk-addons \
>     task-arago-test \
>     bridge-utils \
>     "
>
> Denys
>
>> Thanks for the review,
>> Carlos
>>
>> On 12/06/2012 02:30 PM, Cooper Jr., Franklin wrote:
>>> Can't task-arago-tisdk-addons be used instead of creating this new task-arago-test-addons recipe? The majority of the content in arago-test-addons is provided by task-arago-addons and the remainder is provided by tasks your pulling into the test image recipe. Other than having a slightly bloated file system with additional tools/libraries is there any reason you can't reuse some of the other tasks?
>>>
>>>> -----Original Message-----
>>>> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>>>> bounces@arago-project.org] On Behalf Of Hernandez, Carlos
>>>> Sent: Wednesday, December 05, 2012 1:54 PM
>>>> To: meta-arago@arago-project.org
>>>> Subject: [meta-arago] [PATCH] Define arago-test-image
>>>>
>>>> This filesystem image includes test appplications used by Linux validation team.
>>>>
>>>> Please consider it for meta-arago project. Thanks, Carlos
>>>>
>>>>
>>>>
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>>


[-- Attachment #2: 0001-Define-arago-test-image.patch --]
[-- Type: text/x-patch, Size: 2369 bytes --]

From 390814230637c81f4c5e95b49f869d40857e3663 Mon Sep 17 00:00:00 2001
From: Carlos Hernandez <ceh@ti.com>
Date: Thu, 6 Dec 2012 17:31:45 -0500
Subject: [PATCH] Define arago-test-image

This filesystem image includes test appplications used by
Linux validation team.

Signed-off-by: Carlos Hernandez <ceh@ti.com>
---
 .../recipes-core/images/arago-test-image.bb        |   22 ++++++++++++++++++++
 .../recipes-core/tasks/task-arago-test-addons.bb   |   22 ++++++++++++++++++++
 2 files changed, 44 insertions(+), 0 deletions(-)
 create mode 100644 meta-arago-distro/recipes-core/images/arago-test-image.bb
 create mode 100644 meta-arago-distro/recipes-core/tasks/task-arago-test-addons.bb

diff --git a/meta-arago-distro/recipes-core/images/arago-test-image.bb b/meta-arago-distro/recipes-core/images/arago-test-image.bb
new file mode 100644
index 0000000..3f52729
--- /dev/null
+++ b/meta-arago-distro/recipes-core/images/arago-test-image.bb
@@ -0,0 +1,22 @@
+# Arago System Test image
+# gives you test applications
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58"
+
+require arago-image.inc
+
+COMPATIBLE_MACHINE = "omap3|dm365|omapl138|ti813x|ti814x|ti816x|omap4|ti33x"
+
+IMAGE_INSTALL += "\
+    task-arago-base \
+    task-arago-console \
+    task-arago-base-tisdk \
+    task-arago-tisdk-connectivity \
+    task-arago-tisdk-crypto \
+    task-arago-tisdk-multimedia \
+    task-arago-tisdk-addons \
+    task-arago-test \
+    task-arago-test-addons \
+    "
+
+export IMAGE_BASENAME = "arago-test-image"
diff --git a/meta-arago-distro/recipes-core/tasks/task-arago-test-addons.bb b/meta-arago-distro/recipes-core/tasks/task-arago-test-addons.bb
new file mode 100644
index 0000000..00e9ff6
--- /dev/null
+++ b/meta-arago-distro/recipes-core/tasks/task-arago-test-addons.bb
@@ -0,0 +1,22 @@
+DESCRIPTION = "Task to install additional utilities/demos for test image"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+PR = "r0"
+
+ALLOW_EMPTY = "1"
+
+inherit task
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+
+TEST_ADDONS = " \
+    bridge-utils \
+    "
+
+TEST_ADDONS_TI = " \
+    "
+
+RDEPENDS_${PN} = "\
+    ${TEST_ADDONS} \
+    ${TEST_ADDONS_TI} \
+    "
-- 
1.7.0.4


  reply	other threads:[~2012-12-06 22:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-05 19:54 [PATCH] Define arago-test-image Carlos Hernandez
2012-12-06 19:30 ` Cooper Jr., Franklin
2012-12-06 20:28   ` Carlos Hernandez
2012-12-06 20:33     ` Denys Dmytriyenko
2012-12-06 22:23       ` Carlos Hernandez [this message]
2012-12-06 23:52         ` [PATCH v2] " Denys Dmytriyenko
2012-12-07 13:59           ` Hernandez, Carlos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C11ADD.5010803@ti.com \
    --to=ceh@ti.com \
    --cc=denys@ti.com \
    --cc=fcooper@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.