From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Gardner <tim.gardner@canonical.com>
Subject: Re: [PATCH 3.7-rc8] ttm: Fix possible _manager memory allocation
 oops
Date: Thu, 06 Dec 2012 16:05:27 -0700
Message-ID: <50C124B7.4070502@canonical.com>
References: <1354810806-81681-1-git-send-email-tim.gardner@canonical.com> <CAPM=9ty_PfiQ9Cd5CRNnQbZ7Ea-69qCUR7JM=BA-n_egDnOE5g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CAPM=9ty_PfiQ9Cd5CRNnQbZ7Ea-69qCUR7JM=BA-n_egDnOE5g@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Dave Airlie <airlied@gmail.com>
Cc: linux-kernel@vger.kernel.org, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, dri-devel@lists.freedesktop.org, David Howells <dhowells@redhat.com>, Dave Airlie <airlied@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

On 12/06/2012 03:46 PM, Dave Airlie wrote:

>>
>>          ttm_page_pool_init_locked(&_manager->wc_pool, GFP_HIGHUSER, "wc");
>>
>> @@ -817,6 +821,7 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages)
>>                                     &glob->kobj, "pool");
>>          if (unlikely(ret != 0)) {
>>                  kobject_put(&_manager->kobj);
>> +               kfree(_manager);
>>                  _manager = NULL;
>
> I don;t think this is, since the kobject_put shuold free it.
>

kobject_put only frees memory referenced by kobj, but not the memory 
pointed at by _manager.

rtg
-- 
Tim Gardner tim.gardner@canonical.com