From: Andrew Gallatin <gallatin@myri.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/1] fix vlan transmit performance
Date: Thu, 06 Dec 2012 19:10:58 -0500 [thread overview]
Message-ID: <50C13412.9040600@myri.com> (raw)
In-Reply-To: <1354837321.2828.86.camel@bwh-desktop.uk.solarflarecom.com>
On 12/06/12 18:42, Ben Hutchings wrote:
>
> My answer would be: leave reorder_hdr enabled per default. In fact,
> perhaps the VLAN driver's TX path should ignore it if the underlying
> device has non-zero vlan_features. (It's already ignored if the
> underlying device has NETIF_F_VLAN_TX.)
Thanks for the feedback. I knew I was missing something!
I will try your approach, unless you beat me to it.
I assume sfc is also impacted by this..?
Drew
next prev parent reply other threads:[~2012-12-07 0:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 20:54 [PATCH net-next 0/1] fix vlan transmit performance Andrew Gallatin
2012-12-06 20:54 ` [PATCH net-next 1/1] vlan: restore offload use on vlan transmit Andrew Gallatin
2012-12-06 23:43 ` Ben Hutchings
2012-12-06 23:42 ` [PATCH net-next 0/1] fix vlan transmit performance Ben Hutchings
2012-12-07 0:10 ` Andrew Gallatin [this message]
2012-12-07 17:32 ` Andrew Gallatin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C13412.9040600@myri.com \
--to=gallatin@myri.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.