Re: [PATCH v7 3/9] Introduce scsi_device_being_removed()

[Bart Van Assche <bvanassche@acm.org>]

On 12/07/12 09:40, Rolf Eike Beer wrote:
>> diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
>> index 55367b0..767dd16 100644
>> --- a/include/scsi/scsi_device.h
>> +++ b/include/scsi/scsi_device.h
>> @@ -442,6 +442,11 @@ static inline int scsi_device_created(struct
>> scsi_device *sdev)
>>      return sdev->sdev_state == SDEV_CREATED ||
>>          sdev->sdev_state == SDEV_CREATED_BLOCK;
>>  }
>> +static inline int scsi_device_being_removed(struct scsi_device *sdev)
>> +{
>> +    return sdev->sdev_state == SDEV_CANCEL ||
>> +        sdev->sdev_state == SDEV_DEL;
>> +}
>>
>>  /* accessor functions for the SCSI parameters */
>>  static inline int scsi_device_sync(struct scsi_device *sdev)
>
> Newline missing before the new function.

Hello Rolf,

Well spotted. Did you realize I had left out the newline on purpose, to 
preserve consistency with the rest of the header file ?

Thanks,

Bart.