All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: "Fioravante, Matthew E." <Matthew.Fioravante@jhuapl.edu>,
	Matt Wilson <msw@amazon.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] docs: check for documentation generation tools in docs/configure.
Date: Fri, 7 Dec 2012 10:35:51 +0100	[thread overview]
Message-ID: <50C1B877.5000805@citrix.com> (raw)
In-Reply-To: <1354792014-23685-1-git-send-email-ian.campbell@citrix.com>

On 06/12/12 12:06, Ian Campbell wrote:
> diff --git a/config/Docs.mk.in b/config/Docs.mk.in
> new file mode 100644
> index 0000000..b6ab6fe
> --- /dev/null
> +++ b/config/Docs.mk.in
> @@ -0,0 +1,20 @@
> +# Prefix and install folder
> +prefix              := @prefix@
> +PREFIX              := $(prefix)
> +exec_prefix         := @exec_prefix@
> +libdir              := @libdir@
> +LIBDIR              := $(libdir)
> +
> +# Tools
> +PS2PDF              := @PS2PDF@
> +DVIPS               := @DVIPS@
> +LATEX               := @LATEX@
> +FIG2DEV             := @FIG2DEV@
> +LATEX2HTML          := @LATEX2HTML@

Didn't we drop all the Latex stuff from Docs? I've did a quick grep and
it seems it's still used by xen-api related docs... What I cannot find
is any user for LATEX2HTML, can't we remove than one?

> @@ -26,10 +26,12 @@ all: build
>
>  .PHONY: build
>  build: html txt man-pages figs
> -	@if which $(DOT) 1>/dev/null 2>/dev/null ; then              \
> -	$(MAKE) -C xen-api build ; else                              \
> -        echo "Graphviz (dot) not installed; skipping xen-api." ; fi
> +ifdef DOT
> +	$(MAKE) -C xen-api build
>  	rm -f *.aux *.dvi *.bbl *.blg *.glo *.idx *.ilg *.log *.ind *.toc
> +else
> +	@echo "Graphviz (dot) not installed; skipping xen-api."
> +endif

Don't we need the latex stuff to build xen-api docs? For the xen-api
Makefile to succeed we seem to need PS2PDF, LATEX, DOT, DVIPS and NEATO.

  parent reply	other threads:[~2012-12-07  9:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06 11:06 [PATCH] docs: check for documentation generation tools in docs/configure Ian Campbell
2012-12-06 20:42 ` Matt Wilson
2012-12-07  9:35 ` Roger Pau Monné [this message]
2012-12-07 10:37   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C1B877.5000805@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=Matthew.Fioravante@jhuapl.edu \
    --cc=ian.campbell@citrix.com \
    --cc=msw@amazon.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.