From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThLhq-0005TH-6Q for qemu-devel@nongnu.org; Sat, 08 Dec 2012 09:48:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ThLho-00083r-SV for qemu-devel@nongnu.org; Sat, 08 Dec 2012 09:48:42 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38952 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThLho-00083h-AT for qemu-devel@nongnu.org; Sat, 08 Dec 2012 09:48:40 -0500 Message-ID: <50C35342.8090009@suse.de> Date: Sat, 08 Dec 2012 15:48:34 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1354917127-29718-1-git-send-email-rth@twiddle.net> <1354917127-29718-2-git-send-email-rth@twiddle.net> In-Reply-To: <1354917127-29718-2-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] softfloat: Fix uint64_to_float64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Peter Maydell , qemu-devel@nongnu.org Am 07.12.2012 22:52, schrieb Richard Henderson: > The interface to normalizeRoundAndPackFloat64 requires that the > high bit be clear. Perform one shift-right-and-jam if needed. >=20 > Signed-off-by: Richard Henderson > --- > fpu/softfloat.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/fpu/softfloat.c b/fpu/softfloat.c > index 8413146..62830d7 100644 > --- a/fpu/softfloat.c > +++ b/fpu/softfloat.c > @@ -1273,9 +1273,14 @@ float64 int64_to_float64( int64 a STATUS_PARAM ) > =20 > float64 uint64_to_float64( uint64 a STATUS_PARAM ) > { > - if ( a =3D=3D 0 ) return float64_zero; > - return normalizeRoundAndPackFloat64( 0, 0x43C, a STATUS_VAR ); > + int exp =3D 0x43C; Extra space before number. > =20 > + if ( a =3D=3D 0 ) return float64_zero; > + if ( (int64_t)a < 0 ) { > + shift64RightJamming(a, 1, &a); > + exp +=3D 1; > + } > + return normalizeRoundAndPackFloat64( 0, exp, a STATUS_VAR ); > } > =20 > /*--------------------------------------------------------------------= -------- Shouldn't we be updating the Coding Style on all lines we touch? The shift line matches it but the normalize and ifs don't. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg