From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThLm9-0007Uy-Ho for qemu-devel@nongnu.org; Sat, 08 Dec 2012 09:53:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ThLm8-0000cv-Cp for qemu-devel@nongnu.org; Sat, 08 Dec 2012 09:53:09 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39323 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThLm8-0000cr-3Q for qemu-devel@nongnu.org; Sat, 08 Dec 2012 09:53:08 -0500 Message-ID: <50C35450.7070702@suse.de> Date: Sat, 08 Dec 2012 15:53:04 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1354917127-29718-1-git-send-email-rth@twiddle.net> <1354917127-29718-3-git-send-email-rth@twiddle.net> In-Reply-To: <1354917127-29718-3-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] softfloat: Implement uint64_to_float128 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Peter Maydell , qemu-devel@nongnu.org Am 07.12.2012 22:52, schrieb Richard Henderson: > Signed-off-by: Richard Henderson > --- > fpu/softfloat.c | 8 ++++++++ > fpu/softfloat.h | 3 +++ > 2 files changed, 11 insertions(+) >=20 > diff --git a/fpu/softfloat.c b/fpu/softfloat.c > index 62830d7..d3290d8 100644 > --- a/fpu/softfloat.c > +++ b/fpu/softfloat.c > @@ -1337,6 +1337,14 @@ float128 int64_to_float128( int64 a STATUS_PARAM= ) > =20 > } > =20 > +float128 uint64_to_float128( uint64 a STATUS_PARAM ) Update the parenthesis style as well? You adopted QEMU's style below. > +{ > + if (a =3D=3D 0) { > + return float128_zero; > + } > + return normalizeRoundAndPackFloat128(0, 0x406E, a, 0 STATUS_VAR); > +} > + > /*--------------------------------------------------------------------= -------- > | Returns the result of converting the single-precision floating-point= value > | `a' to the 32-bit two's complement integer format. The conversion i= s > diff --git a/fpu/softfloat.h b/fpu/softfloat.h > index d8999b3..c1ea196 100644 > --- a/fpu/softfloat.h > +++ b/fpu/softfloat.h > @@ -237,6 +237,7 @@ float64 int64_to_float64( int64 STATUS_PARAM ); > float64 uint64_to_float64( uint64 STATUS_PARAM ); > floatx80 int64_to_floatx80( int64 STATUS_PARAM ); > float128 int64_to_float128( int64 STATUS_PARAM ); > +float128 uint64_to_float128( uint64 STATUS_PARAM ); Ditto? I would've expected checkpatch.pl complaints... Andreas > =20 > /*--------------------------------------------------------------------= -------- > | Software half-precision conversion routines. > @@ -630,6 +631,8 @@ INLINE int float128_is_any_nan(float128 a) > ((a.low !=3D 0) || ((a.high & 0xffffffffffffLL) !=3D 0)); > } > =20 > +#define float128_zero make_float128(0, 0) > + > /*--------------------------------------------------------------------= -------- > | The pattern for a default generated quadruple-precision NaN. > *---------------------------------------------------------------------= -------*/ >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg