From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThNh8-0007yB-Rc for qemu-devel@nongnu.org; Sat, 08 Dec 2012 11:56:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ThNh7-0004BX-Rl for qemu-devel@nongnu.org; Sat, 08 Dec 2012 11:56:06 -0500 Received: from cantor2.suse.de ([195.135.220.15]:42789 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThNh7-0004BT-LQ for qemu-devel@nongnu.org; Sat, 08 Dec 2012 11:56:05 -0500 Message-ID: <50C3711F.9050508@suse.de> Date: Sat, 08 Dec 2012 17:55:59 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1354979928-19000-1-git-send-email-laurent@vivier.eu> In-Reply-To: <1354979928-19000-1-git-send-email-laurent@vivier.eu> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] linux-user: correctly align types in thunking code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: Peter Maydell , Riku Voipio , qemu-devel@nongnu.org Am 08.12.2012 16:18, schrieb Laurent Vivier: > Signed-off-by: Laurent Vivier > --- > thunk.h | 22 +++++++++++++++++----- > 1 file changed, 17 insertions(+), 5 deletions(-) >=20 > diff --git a/thunk.h b/thunk.h > index 87025c3..d3e9f3d 100644 > --- a/thunk.h > +++ b/thunk.h > @@ -151,20 +151,32 @@ static inline int thunk_type_align(const argtype = *type_ptr, int is_host) > case TYPE_CHAR: > return 1; > case TYPE_SHORT: > - return 2; > + if (is_host) { > + return __alignof__(short); Might __alignof__() depend on a certain GCC version? Is it supported by clang? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg