From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 1/2] softfloat: Fix uint64_to_float64
Date: Sat, 08 Dec 2012 18:05:15 +0100 [thread overview]
Message-ID: <50C3734B.3020606@suse.de> (raw)
In-Reply-To: <CAFEAcA9=9dQr-pz6GiGoXyb8hAF8LF_8pCSn4g-HCz7CtmkwRg@mail.gmail.com>
Am 08.12.2012 17:08, schrieb Peter Maydell:
> On 8 December 2012 14:48, Andreas Färber <afaerber@suse.de> wrote:
>> Shouldn't we be updating the Coding Style on all lines we touch? The
>> shift line matches it but the normalize and ifs don't.
>
> fpu/ is a special case because the softfloat library has such
> a bonkers coding style. I tend to update to qemu standard when
> I touch bits of it, but following the existing practice is
> also OK in my opinion.
The same applies to linux-user and much of ppc code (spaces before
parenthesis, no braces). The only agreed-on way to address this is by
fixing the parts we touch - no veto here, but seems trivial enough to
fix. Otherwise the situation won't ever improve.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-12-08 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 21:52 [Qemu-devel] [PATCH v2 0/2] soft-float fixes for target-s390x Richard Henderson
2012-12-07 21:52 ` [Qemu-devel] [PATCH 1/2] softfloat: Fix uint64_to_float64 Richard Henderson
2012-12-08 10:42 ` Peter Maydell
2012-12-08 14:48 ` Andreas Färber
2012-12-08 16:08 ` Peter Maydell
2012-12-08 17:05 ` Andreas Färber [this message]
2012-12-07 21:52 ` [Qemu-devel] [PATCH 2/2] softfloat: Implement uint64_to_float128 Richard Henderson
2012-12-08 10:43 ` Peter Maydell
2012-12-08 14:53 ` Andreas Färber
-- strict thread matches above, loose matches on Subject: below --
2012-12-11 17:21 [Qemu-devel] [PATCH v3 0/2] soft-float-fixes for target-s390x Richard Henderson
2012-12-11 17:21 ` [Qemu-devel] [PATCH 1/2] softfloat: Fix uint64_to_float64 Richard Henderson
2012-12-11 17:34 ` Peter Maydell
2012-12-31 18:09 [Qemu-devel] [PATCH v4 0/2] soft-float-fixes for target-s390x Richard Henderson
2012-12-31 18:09 ` [Qemu-devel] [PATCH 1/2] softfloat: Fix uint64_to_float64 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C3734B.3020606@suse.de \
--to=afaerber@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.