From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: Garrett Cooper <yanegomi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] [RFC] osm_log printing incorrectly assumes that pthread_t is not opaque type
Date: Sun, 09 Dec 2012 10:54:48 +0100 [thread overview]
Message-ID: <50C45FE8.5020502@acm.org> (raw)
In-Reply-To: <alpine.BSF.2.00.1212090125590.64779-Fqwm7F1mg36Nj9Bq2fkWzw@public.gmane.org>
On 12/09/12 10:26, Garrett Cooper wrote:
> +#if defined(__FreeBSD__)
> + "%s %02d %02d:%02d:%02d %06d [%p] 0x%02x -> %s",
> +#else
> "%s %02d %02d:%02d:%02d %06d [%04X] 0x%02x -> %s",
> +#endif
Please cast the pthread_t value to an unsigned long long or another
integral type. Such #ifdefs are a pain to maintain.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-12-09 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-09 9:26 [PATCH] [RFC] osm_log printing incorrectly assumes that pthread_t is not opaque type Garrett Cooper
[not found] ` <alpine.BSF.2.00.1212090125590.64779-Fqwm7F1mg36Nj9Bq2fkWzw@public.gmane.org>
2012-12-09 9:54 ` Bart Van Assche [this message]
[not found] ` <50C45FE8.5020502-HInyCGIudOg@public.gmane.org>
2012-12-09 10:03 ` Garrett Cooper
2012-12-09 17:43 ` Alex Netes
[not found] ` <75EE638CB68A864F90627D3D06A189A859350715-SlGPd/IId7auSA5JZHE7gA@public.gmane.org>
2012-12-09 19:56 ` Garrett Cooper
[not found] ` <CAGH67wQ=-Mn3_HMy7=VOT2am99qbjrXcOpC6+_PCSW6xuyVvRA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-10 6:10 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C45FE8.5020502@acm.org \
--to=bvanassche-hinycgiudog@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=yanegomi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.