Re: [PATCH 3/3] iio: add rtc-driver for HID sensors of type time

[Lars-Peter Clausen <lars@metafoo.de>]

On 12/09/2012 07:16 PM, Alexander Holler wrote:
> Am 09.12.2012 17:40, schrieb Alexander Holler:
>> Am 09.12.2012 13:55, schrieb Lars-Peter Clausen:
>>> On 12/09/2012 01:21 PM, Alexander Holler wrote:
>>>> This driver makes the time from HID sensors (hubs) which are offering
>>>> such available like any other RTC does.
>>>>
>>>> Currently the time can only be read. Setting the time must be done
>>>> through sending a report, which currently isn't supported by
>>>> hid-sensor-hub.
>>>>
>>>> It is necessary that all values like year, month etc, are send as
>>>> 8bit values (1 byte each) and all of them in 1 report. Also the
>>>> spec HUTRR39b doesn't define the range of the year field, we
>>>> tread it as 0 - 99 because that's what most RTCs I know about are
>>>> offering.
>>>
>>> I don't think we should register a IIO device for this. Just an RTC
>>> device
>>> should be fully sufficient.
>>>
>>
>> You would have to implement all the used services hid-sensor-hub offers
>> in the rtc-driver again.
> 
> Besides that, time is part of the spec for HID sensors, which makes
> sense. Making that available as a RTC to read/set the time is imho the
> best to way support that. If you want a driver which doesn't use the HID
> sensor hub framework (or iio), you would either have to define your own
> standard or make sure it is interoperable with the HID sensor hub
> framework, which might not be trivial.

I agree with what you wrote above. It just doesn't make sense to register a IIO
device for a RTC type device. Just rip out all the IIO related bits from the
driver and it will be fine.

- Lars