From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?6rmA7Iq57Jqw?= Subject: Re: [PATCH -next] drm/exynos/iommu: fix return value check in drm_create_iommu_mapping() Date: Mon, 10 Dec 2012 15:14:17 +0900 Message-ID: <50C57DB9.8070100@samsung.com> References: Reply-To: sw0312.kim@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: Sender: linux-kernel-owner@vger.kernel.org To: Wei Yongjun Cc: inki.dae@samsung.com, jy0922.shim@samsung.com, kyungmin.park@samsung.com, airlied@linux.ie, yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sw0312.kim@samsung.com List-Id: dri-devel@lists.freedesktop.org On 2012=EB=85=84 12=EC=9B=94 07=EC=9D=BC 21:50, Wei Yongjun wrote: > From: Wei Yongjun >=20 > In case of error, function arm_iommu_create_mapping() returns > ERR_PTR() and never returns NULL. The NULL test in the return > value check should be replaced with IS_ERR(). >=20 > Signed-off-by: Wei Yongjun > --- > drivers/gpu/drm/exynos/exynos_drm_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.c b/drivers/gpu/= drm/exynos/exynos_drm_iommu.c > index 09db198..3b3d3a6 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_iommu.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.c > @@ -56,7 +56,7 @@ int drm_create_iommu_mapping(struct drm_device *drm= _dev) > mapping =3D arm_iommu_create_mapping(&platform_bus_type, priv->da_s= tart, > priv->da_space_size, > priv->da_space_order); > - if (!mapping) > + if (IS_ERR(mapping)) > return -ENOMEM; One more fix is needed here. - return -ENOMEM; + return PTR_ERR(mapping); > =20 > dev->dma_parms =3D devm_kzalloc(dev, sizeof(*dev->dma_parms), >=20 >=20 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >=20 --=20 Seung-Woo Kim Samsung Software R&D Center --