From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vaibhav Hiremath Date: Mon, 10 Dec 2012 09:14:06 +0000 Subject: Re: [PATCH] da8xx: Allow use by am33xx based devices Message-Id: <50C5A50E.4070602@ti.com> List-Id: References: <1351698968-3965-1-git-send-email-panto@antoniou-consulting.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Manjunathappa, Prakash" Cc: "Valkeinen, Tomi" , "davinci-linux-open-source@linux.davincidsp.com" , "Porter, Matt" , "linux-fbdev@vger.kernel.org" , "FlorianSchandinat@gmx.de" , Koen Kooi , Pantelis Antoniou , "linux-kernel@vger.kernel.org" , "Dill, Russ" , "linux-omap@vger.kernel.org" On 12/6/2012 1:38 PM, Manjunathappa, Prakash wrote: > Hi Tomi, > > On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote: >> Hi, >> >> On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote: >>> This driver can be used for AM33xx devices, like the popular beaglebone. >>> >>> Signed-off-by: Pantelis Antoniou >>> --- >>> drivers/video/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >>> index 9791d10..e7868d8 100644 >>> --- a/drivers/video/Kconfig >>> +++ b/drivers/video/Kconfig >>> @@ -2202,7 +2202,7 @@ config FB_SH7760 >>> >>> config FB_DA8XX >>> tristate "DA8xx/OMAP-L1xx Framebuffer support" >>> - depends on FB && ARCH_DAVINCI_DA8XX >>> + depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX) >> >> Agreed this is present on da8xx and am33xx, but moving forward for >> supporting DT, we should be avoiding these dependencies. So instead >> change this to remove machine dependencies. >> > > I could be wrong here, having dependency on platform seems to be right. > Otherwise may lead to build errors for other platforms. No, it should not result in to build error unless driver uses some platform specific api's. Thanks, Vaibhav > Please ignore my > comments and accept this patch. > > Thanks, > Prakash > _______________________________________________ > Davinci-linux-open-source mailing list > Davinci-linux-open-source@linux.davincidsp.com > http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vaibhav Hiremath Subject: Re: [PATCH] da8xx: Allow use by am33xx based devices Date: Mon, 10 Dec 2012 14:32:06 +0530 Message-ID: <50C5A50E.4070602@ti.com> References: <1351698968-3965-1-git-send-email-panto@antoniou-consulting.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:44429 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751064Ab2LJJCX (ORCPT ); Mon, 10 Dec 2012 04:02:23 -0500 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Manjunathappa, Prakash" Cc: "Valkeinen, Tomi" , "davinci-linux-open-source@linux.davincidsp.com" , "Porter, Matt" , "linux-fbdev@vger.kernel.org" , "FlorianSchandinat@gmx.de" , Koen Kooi , Pantelis Antoniou , "linux-kernel@vger.kernel.org" , "Dill, Russ" , "linux-omap@vger.kernel.org" On 12/6/2012 1:38 PM, Manjunathappa, Prakash wrote: > Hi Tomi, > > On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote: >> Hi, >> >> On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote: >>> This driver can be used for AM33xx devices, like the popular beaglebone. >>> >>> Signed-off-by: Pantelis Antoniou >>> --- >>> drivers/video/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >>> index 9791d10..e7868d8 100644 >>> --- a/drivers/video/Kconfig >>> +++ b/drivers/video/Kconfig >>> @@ -2202,7 +2202,7 @@ config FB_SH7760 >>> >>> config FB_DA8XX >>> tristate "DA8xx/OMAP-L1xx Framebuffer support" >>> - depends on FB && ARCH_DAVINCI_DA8XX >>> + depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX) >> >> Agreed this is present on da8xx and am33xx, but moving forward for >> supporting DT, we should be avoiding these dependencies. So instead >> change this to remove machine dependencies. >> > > I could be wrong here, having dependency on platform seems to be right. > Otherwise may lead to build errors for other platforms. No, it should not result in to build error unless driver uses some platform specific api's. Thanks, Vaibhav > Please ignore my > comments and accept this patch. > > Thanks, > Prakash > _______________________________________________ > Davinci-linux-open-source mailing list > Davinci-linux-open-source@linux.davincidsp.com > http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source >