From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Ti55O-00055y-SN for mharc-grub-devel@gnu.org; Mon, 10 Dec 2012 10:16:02 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti55B-00055A-Gc for grub-devel@gnu.org; Mon, 10 Dec 2012 10:16:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ti554-0007Mu-21 for grub-devel@gnu.org; Mon, 10 Dec 2012 10:15:49 -0500 Received: from mail-bk0-f41.google.com ([209.85.214.41]:52109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti553-0007Mg-R9 for grub-devel@gnu.org; Mon, 10 Dec 2012 10:15:41 -0500 Received: by mail-bk0-f41.google.com with SMTP id jg9so1257471bkc.0 for ; Mon, 10 Dec 2012 07:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=a79u6YFAhi86W0TLixgptzrevEdIFiXFQxLz3t9kX3E=; b=DyFZDoyop2mj6h/L0fA6ka/9A0pin+2F2zEwadRFJhkNioY1460uCj/kF2lmmhtswX uiFR0eJc1oFnb5okyZAKQQsHi09zuqwTTG+WQ1yJrVIbhAXyFCzD7qViN9flcdRc+7bz 9Ig4a+vPOa5KnZ0kLxjv+XiLY44O+ILPpFveCTARndbogIFpGU1M2COdivU3x6tvJadD ODrhI7bTpZetY6Q5l3ISwJH2W0DCwZp6774FBuEkm8L1V+j9koay2wMCmU7WKkVHGrnw T8sWKLI8GmnoZkf2y5BOC8AbBJTQHhZrO2Enus/6ecE+EUvLmH7mUuspOJPOJb/tfUGO otzg== Received: by 10.204.4.131 with SMTP id 3mr4480768bkr.25.1355152540819; Mon, 10 Dec 2012 07:15:40 -0800 (PST) Received: from debian.x201.phnet (125-234.197-178.cust.bluewin.ch. [178.197.234.125]) by mx.google.com with ESMTPS id l17sm14404399bkw.12.2012.12.10.07.15.38 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 10 Dec 2012 07:15:39 -0800 (PST) Message-ID: <50C5FC82.2030209@gmail.com> Date: Mon, 10 Dec 2012 16:15:14 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121122 Icedove/10.0.11 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: Patch for better size handling of GRUB edit or shell References: <5071720C.1060107@reinform.de> In-Reply-To: <5071720C.1060107@reinform.de> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig1C10CA98D679ABD0AE041C7F" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.214.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2012 15:16:01 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1C10CA98D679ABD0AE041C7F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07.10.2012 14:14, Dr. Tilmann Bubeck wrote: > Hi >=20 > especially on low resolution systems (e.g. VirtualBox with 800x600) the= > GRUB edit window (gfxmenu/view.c) and GRUB shell are hard to use, > because they only use 70% of the available width, which is 800px * 70% = =3D > 560px. Using the borders around the view makes the window even smaller.= > Please find attached a screenshot ("grub-unchanged-640x480-editor.png")= > showing the unmodified GRUB running in gfxmode=3Dauto which is 800x600.= > You can see, that the edit window is ridiculus small. >=20 > Please find attached a patch, which changes the way, the view size is > constructed. Before the patch it always used 70% of the available width= =2E > The patch checks if a full line of characters is fitting in these 70% > and otherwise uses the available screen width, if it is not enough. >=20 > You can see the result in the second screenshot > ("grub-640x480-editor.png") attached. There is now much more room for > the editor, without loosing the 70% style if enough space is available.= >=20 > Could you please apply that patch or give any feedback? >=20 Patch applied after fixing its unjustified performance overhead (I adapted the code a bit for it. > Thanks! >=20 > Tilmann Bubeck >=20 >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig1C10CA98D679ABD0AE041C7F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAlDF/IIACgkQNak7dOguQglqCQD/YuOQ2mFm/RZff2yTr7HLv6W7 x756pekGP0+cjV6FM4oBAJsEojJjcgI1wcB50iWRA3VCV/n4BTtWCTlpthe6JP5Z =OS6b -----END PGP SIGNATURE----- --------------enig1C10CA98D679ABD0AE041C7F--