All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: WONG Sheng Chao <wong@isir.upmc.fr>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai] Compiling I-pipe patched kernel on beaglebone from Angstrom branch
Date: Mon, 10 Dec 2012 20:07:47 +0100	[thread overview]
Message-ID: <50C63303.407@xenomai.org> (raw)
In-Reply-To: <4f87d2b280543885c9cefc9b9d376fa9@isir.upmc.fr>

On 12/10/2012 07:08 PM, WONG Sheng Chao wrote:

>>>>> The first post was just fine. But two things:
>>>>> - we do not want the .config in the post patch
>>>>
>>>> I will redo the post patch without the .config file
>>>>
>>>>> - the post patch does not re-add the changes removed by the
>>>>> pre-patch in
>>>>> arch/arm/common/gic.c, which makes it look really suspicious.
>>>>
>>>> as for the arch/arm/common/gic.c, it did not exist in the original
>>>> vendor code (Angstrom). Since it did not exists, there were an 
>>>> error
>>>> when i ran the .prepare-kernel script. So what I did was copy the
>>>> arch/arm/common/gic.c from the vanilla linux kernel to my vender
>>>> code.
>>>> I did not modify the arch/arm/common/gic.c there after thus the 
>>>> post
>>>> patch does not do anything to it.
>>>>
>>>> Does that makes sense? or did I miss somethin
>>>
>>> I am sorry i made a mistake, the file i mentioned above is
>>> arch/arm/plat-mxc/gic.c
>>>
>>> As for arch/arm/common/gic.c, i pre-patch it to the
>>> vanilla-kernel-3.2.21.
>>>
>>> I don't quite understand, since I did not do any changes in this 
>>> file
>>> after i patch it with ipipe, so isn't it logical that the post-patch
>>> does not re-add since there is nothing to add?
>>
>>
>> If you did not modify it, then the pre-patch should not contain 
>> anything
>> with regard to that file. Could you give me the url to the vendor git
>> repository and the modified branch so that I can generate the patches
>> myself and compare ?
> 
> 
> Since I was using bitbake recipe to get the vendor source code, I 
> created my own git repository for the kernel source
> 
> https://github.com/shengchao/beaglebone-angstrom-xenomai
> 
> the master branch contains the original source from the vendor
> 
> and the xenomai branch is the one with pre-patch, ipipe_patch and 
> post_patch applied.


As I already said, what you should put under source control is the
I-pipe kernel, putting xenomai in the sources defeats the purpose of
having xenomai separated from the I-pipe patch.

-- 
                                                                Gilles.


  reply	other threads:[~2012-12-10 19:07 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.0.1354186801.18650.xenomai@xenomai.org>
2012-11-29 12:16 ` [Xenomai] Compiling I-pipe patched kernel on beaglebone from Angstrom branch Stephan Kappertz
2012-11-30  8:54   ` WONG Sheng Chao
2012-11-30 11:45     ` Michael Haberler
2012-11-30 13:42       ` Gilles Chanteperdrix
2012-11-30 19:22         ` Michael Haberler
2012-12-02 13:53           ` WONG Sheng Chao
2012-12-02 14:45             ` Gilles Chanteperdrix
2012-12-02 15:15               ` WONG Sheng Chao
2012-12-02 16:14                 ` Gilles Chanteperdrix
2012-12-03 14:31                   ` WONG Sheng Chao
2012-12-03 18:30                     ` WONG Sheng Chao
2012-12-03 19:57                       ` Gilles Chanteperdrix
2012-12-04  9:26                         ` WONG Sheng Chao
2012-12-04  9:45                           ` WONG Sheng Chao
2012-12-04 19:29                             ` Gilles Chanteperdrix
2012-12-10 18:08                               ` WONG Sheng Chao
2012-12-10 19:07                                 ` Gilles Chanteperdrix [this message]
2012-12-10 20:23                                   ` WONG Sheng Chao
2012-12-10 20:32                                     ` Gilles Chanteperdrix
     [not found] <mailman.2.1354034873.1423.xenomai@xenomai.org>
2012-11-27 18:42 ` Stephan Kappertz
2012-11-27 20:05   ` WONG Sheng Chao
2012-11-23  9:45 WONG Sheng Chao
2012-11-23  9:58 ` Gilles Chanteperdrix
2012-11-23 12:35   ` WONG Sheng Chao
2012-11-23 16:29     ` Gilles Chanteperdrix
2012-11-23 17:22       ` WONG Sheng Chao
2012-11-23 17:45         ` Gilles Chanteperdrix
2012-11-27 16:40           ` WONG Sheng Chao
2012-11-27 16:52             ` WONG Sheng Chao
2012-11-27 18:00             ` Gilles Chanteperdrix
2012-11-28 15:12               ` WONG Sheng Chao
2012-11-28 17:40                 ` WONG Sheng Chao
2012-11-28 18:14                   ` Gilles Chanteperdrix
2012-11-28 18:49                     ` WONG Sheng Chao
2012-11-28 18:57                       ` Gilles Chanteperdrix
2012-11-28 19:34                         ` WONG Sheng Chao
2012-11-28 19:55                           ` Gilles Chanteperdrix
2012-11-28 20:22                             ` WONG Sheng Chao
2012-11-29 12:10                             ` WONG Sheng Chao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C63303.407@xenomai.org \
    --to=gilles.chanteperdrix@xenomai.org \
    --cc=wong@isir.upmc.fr \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.