From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
matthew.fioravante@jhuapl.edu, xen-devel@lists.xen.org
Subject: Re: [PATCH 14/14] stubdom/Makefile: Fix gmp extract rule
Date: Mon, 10 Dec 2012 16:28:37 -0500 [thread overview]
Message-ID: <50C65405.4070708@tycho.nsa.gov> (raw)
In-Reply-To: <20121210212403.GB5833@type.youpi.perso.aquilenet.fr>
On 12/10/2012 04:24 PM, Samuel Thibault wrote:
> Daniel De Graaf, le Mon 10 Dec 2012 14:55:47 -0500, a écrit :
>> gmp-$(XEN_TARGET_ARCH): gmp-$(GMP_VERSION).tar.bz2 $(NEWLIB_STAMPFILE)
>> tar xjf $<
>> + rm $@ -rf || :
>
> I'm realizing...
>
>> mv gmp-$(GMP_VERSION) $@
>> #patch -d $@ -p0 < gmp.patch
>> cd $@; CPPFLAGS="-isystem $(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf/include $(TARGET_CPPFLAGS)" CFLAGS="$(TARGET_CFLAGS)" CC=$(CC) $(GMPEXT) ./configure --disable-shared --enable-static --disable-fft --without-readline --prefix=$(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf
>
> Which is configure invoked here? In the other cases, we have used a
> stampfile, to separate unpacking and configure stages, which avoids the
> issue. Is it because libgmp does not support build out of tree? If so,
> then I'm fine with the rm change, although -rm $@ -rf instead of || :
> would be more readable.
>
> Samuel
>
I didn't look too closely at the reasons why the configure is done here; the
rm is needed regardless of where the configure is done, assuming the tarball
could be touched while the directory exists.
I chose "|| :" instead of -rm because it silences make's output on the failure,
which will be normal the first time it is run. If -rm is preferred, that's
trivial to fix.
--
Daniel De Graaf
National Security Agency
next prev parent reply other threads:[~2012-12-10 21:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 19:55 [PATCH v3 00/14] vTPM new ABI, extensions Daniel De Graaf
2012-12-10 19:55 ` [PATCH 01/14] mini-os/tpm{back, front}: Change shared page ABI Daniel De Graaf
2012-12-14 20:16 ` [PATCH v3.2] " Daniel De Graaf
2012-12-10 19:55 ` [PATCH 02/14] stubdom/vtpm: correct the buffer size returned by TPM_CAP_PROP_INPUT_BUFFER Daniel De Graaf
2012-12-10 19:55 ` [PATCH 03/14] stubdom/vtpm: Support locality field Daniel De Graaf
2012-12-10 19:55 ` [PATCH 04/14] stubdom/vtpm: Allow repoen of closed devices Daniel De Graaf
2012-12-10 19:55 ` [PATCH 05/14] stubdom/vtpm: make state save operation atomic Daniel De Graaf
2012-12-10 19:55 ` [PATCH 06/14] stubdom/grub: send kernel measurements to vTPM Daniel De Graaf
2012-12-10 19:55 ` [PATCH 07/14] stubdom/vtpm: Add locality-5 PCRs Daniel De Graaf
2012-12-10 19:55 ` [PATCH 08/14] stubdom/vtpm: support multiple backends Daniel De Graaf
2012-12-10 19:55 ` [PATCH 09/14] stubdom/vtpm: Add PCR pass-through to hardware TPM Daniel De Graaf
2012-12-14 20:12 ` Daniel De Graaf
2012-12-10 19:55 ` [PATCH 10/14] mini-os/tpmback: set up callbacks before enumeration Daniel De Graaf
2012-12-10 19:55 ` [PATCH 11/14] mini-os/tpmback: Replace UUID field with opaque pointer Daniel De Graaf
2012-12-10 19:55 ` [PATCH 12/14] mini-os/tpmback: add tpmback_get_peercontext Daniel De Graaf
2012-12-10 21:20 ` Samuel Thibault
2012-12-10 21:22 ` Daniel De Graaf
2012-12-10 21:25 ` Samuel Thibault
2012-12-10 19:55 ` [PATCH 13/14] stubdom/vtpm: constrain locality by XSM label Daniel De Graaf
2012-12-10 19:55 ` [PATCH 14/14] stubdom/Makefile: Fix gmp extract rule Daniel De Graaf
2012-12-10 21:24 ` Samuel Thibault
2012-12-10 21:28 ` Daniel De Graaf [this message]
2012-12-10 21:33 ` Samuel Thibault
2012-12-10 20:00 ` [PATCH] drivers/tpm-xen: Change vTPM shared page ABI Daniel De Graaf
2012-12-11 11:52 ` Jan Beulich
2012-12-11 14:55 ` Daniel De Graaf
2013-01-18 15:12 ` [PATCH v3 00/14] vTPM new ABI, extensions Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C65405.4070708@tycho.nsa.gov \
--to=dgdegra@tycho.nsa.gov \
--cc=matthew.fioravante@jhuapl.edu \
--cc=samuel.thibault@ens-lyon.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.