From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiCWa-0002BT-7k for qemu-devel@nongnu.org; Mon, 10 Dec 2012 18:12:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiCWY-0004Ou-VM for qemu-devel@nongnu.org; Mon, 10 Dec 2012 18:12:36 -0500 Received: from cantor2.suse.de ([195.135.220.15]:48653 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiCWY-0004Ol-L9 for qemu-devel@nongnu.org; Mon, 10 Dec 2012 18:12:34 -0500 Message-ID: <50C66C57.9010800@suse.de> Date: Tue, 11 Dec 2012 00:12:23 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1354645978-17362-1-git-send-email-ehabkost@redhat.com> <1355082353-322-1-git-send-email-afaerber@suse.de> <1355082353-322-4-git-send-email-afaerber@suse.de> <20121210180920.GQ4255@otherpad.lan.raisama.net> In-Reply-To: <20121210180920.GQ4255@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 3/4] Really finally kill cpudef config section support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: blauwirbel@gmail.com, imammedo@redhat.com, Anthony Liguori , Riku Voipio , qemu-devel@nongnu.org Am 10.12.2012 19:09, schrieb Eduardo Habkost: > On Sun, Dec 09, 2012 at 08:45:52PM +0100, Andreas F=E4rber wrote: >> Commit 511c68d3af626cb0a39034cb77e7ac64d3a26c0c (finally kill cpudef >> config section support) removed the cpudef parsing support but left >> cpudef_* hooks behind. Remove those. >=20 > The cpudef_* functions have nothing to do with the cpudef config sectio= n > since QEMU 1.2, it is just about initializing CPU-definition-related > data structures, so the patch subject is a bit misleading. My memory tells me they were specifically added for the config file support... git-blame proves me wrong and shows they were added by Johan Cooper and refactored by Blue, explaining his sudden cpudef patch involvement. Sorry. Do you have a proposal for a better text? My reasoning is we should clean up before we forget about it and things stay behind. Andreas >=20 > But I agree with the changes done here, and patch looks good to me, so: >=20 > Reviewed-by: Eduardo Habkost >=20 >=20 >> >> Since TYPE_X86_CPU currently is the only CPU class and CPUs are >> instantiated exclusively through QOM (i.e., cpu_x86_init()), we can us= e >> its class_init to bootstrap the list of model definitions until we hav= e >> these as subclasses. Avoid code movements for x86_cpudef_setup() to no= t >> interfere with the various approaches to drop it in favor of subclasse= s. >> >> Signed-off-by: Andreas F=E4rber >> Cc: Eduardo Habkost >> Cc: Blue Swirl >> --- >> arch_init.c | 7 ------- >> arch_init.h | 1 - >> bsd-user/main.c | 3 --- >> linux-user/main.c | 3 --- >> target-i386/cpu.c | 7 ++++++- >> target-i386/cpu.h | 2 -- >> vl.c | 7 ------- >> 7 Dateien ge=E4ndert, 6 Zeilen hinzugef=FCgt(+), 24 Zeilen entfernt(-= ) >> > [...] >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg