From: Saul Wold <sgw@linux.intel.com>
To: Kang Kai <kai.kang@windriver.com>
Cc: Zhenfeng.Zhao@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] newt: enable python support
Date: Mon, 10 Dec 2012 15:58:54 -0800 [thread overview]
Message-ID: <50C6773E.7000805@linux.intel.com> (raw)
In-Reply-To: <82be931f7271af4863557f93daa29324fcbb439b.1355131760.git.kai.kang@windriver.com>
On 12/10/2012 01:37 AM, Kang Kai wrote:
> Compile newt with python support. There may be packages that need newt's
> python extension.
>
> Add python to DEPENDS. And add patch fix_python_fpic.patch to compile
> python .so module with flag -fPIC.
>
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
> .../newt/files/fix_python_fpic.patch | 11 +++++++++
> meta/recipes-extended/newt/libnewt_0.52.14.bb | 24 +++++++++++++++-----
> 2 files changed, 29 insertions(+), 6 deletions(-)
> create mode 100644 meta/recipes-extended/newt/files/fix_python_fpic.patch
>
> diff --git a/meta/recipes-extended/newt/files/fix_python_fpic.patch b/meta/recipes-extended/newt/files/fix_python_fpic.patch
> new file mode 100644
> index 0000000..d0dbe99
> --- /dev/null
> +++ b/meta/recipes-extended/newt/files/fix_python_fpic.patch
No Patch Header!
Please add Signed-off-by and Upstream-Status to your patches.
Sau!
> @@ -0,0 +1,11 @@
> +--- newt-0.52.14/Makefile.in 2012-12-04 17:27:27.578915801 +0800
> ++++ newt-0.52.14/Makefile.in.new 2012-12-04 17:28:43.274918472 +0800
> +@@ -84,7 +84,7 @@
> + PIFLAGS=`$$ver-config --includes`; \
> + PLDFLAGS=`$$ver-config --ldflags`; \
> + PLFLAGS=`$$ver-config --libs`; \
> +- $(CC) $(CPPFLAGS) $$PIFLAGS $$PCFLAGS -c -o $$ver/snackmodule.o snackmodule.c ;\
> ++ $(CC) $(SHCFLAGS) $(CPPFLAGS) $$PIFLAGS $$PCFLAGS -c -o $$ver/snackmodule.o snackmodule.c ;\
> + $(CC) --shared $$PLDFLAGS $$PLFLAGS $(LDFLAGS) -o $$ver/_snackmodule.so $$ver/snackmodule.o -L. -lnewt $(LIBS);\
> + done || :
> + touch $@
> diff --git a/meta/recipes-extended/newt/libnewt_0.52.14.bb b/meta/recipes-extended/newt/libnewt_0.52.14.bb
> index 0208695..c1ec029 100644
> --- a/meta/recipes-extended/newt/libnewt_0.52.14.bb
> +++ b/meta/recipes-extended/newt/libnewt_0.52.14.bb
> @@ -15,28 +15,40 @@ LICENSE = "LGPLv2"
> LIC_FILES_CHKSUM = "file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605"
>
> # slang needs to be >= 2.2
> -DEPENDS = "slang popt"
> +DEPENDS = "slang popt python"
>
> -PR = "r1"
> +PR = "r2"
>
> SRC_URI = "https://fedorahosted.org/releases/n/e/newt/newt-${PV}.tar.gz \
> file://remove_slang_include.patch \
> file://fix_SHAREDDIR.patch \
> - file://cross_ar.patch"
> + file://cross_ar.patch \
> + file://fix_python_fpic.patch"
>
> SRC_URI[md5sum] = "eb78c6bb658b92ec7198908b5b8d0e37"
> SRC_URI[sha256sum] = "f70f4f58baa60388ddf2e39249ffb00898fb40f2b2767e42e2ab51fe4b40978e"
>
> S = "${WORKDIR}/newt-${PV}"
>
> -EXTRA_OECONF = "--without-python --without-tcl"
> +EXTRA_OECONF = "--without-tcl"
>
> -inherit autotools
> +inherit autotools pythonnative python-dir
>
> -PACKAGES_prepend = "whiptail "
> +EXTRA_OEMAKE = "PYTHONVERS=${PYTHON_DIR}"
> +
> +export STAGING_INCDIR
> +export STAGING_LIBDIR
> +
> +export BUILD_SYS
> +export HOST_SYS
> +
> +PACKAGES_prepend = "whiptail ${PN}-python "
>
> do_configure_prepend() {
> sh autogen.sh
> }
>
> FILES_whiptail = "${bindir}/whiptail"
> +FILES_${PN}-dbg += "${PYTHON_SITEPACKAGES_DIR}/.debug/"
> +FILES_${PN}-python = "${PYTHON_SITEPACKAGES_DIR}/*"
> +FILES_${PN}-staticdev = "${libdir}/*.a"
>
next prev parent reply other threads:[~2012-12-11 0:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 9:37 [PATCH 0/2] V2: Enable python support for libnewt and libuser Kang Kai
2012-12-10 9:37 ` [PATCH 1/2] newt: enable python support Kang Kai
2012-12-10 23:58 ` Saul Wold [this message]
2012-12-10 9:37 ` [PATCH 2/2] libuser: " Kang Kai
-- strict thread matches above, loose matches on Subject: below --
2012-12-12 10:48 [PATCH 0/2] V3: Enable python support for libnewt and libuser Kang Kai
2012-12-12 10:48 ` [PATCH 1/2] newt: enable python support Kang Kai
2012-12-06 8:16 [PATCH 0/2] Enable python support for libnewt and libuser Kang Kai
2012-12-06 8:16 ` [PATCH 1/2] newt: enable python support Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C6773E.7000805@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=Zhenfeng.Zhao@windriver.com \
--cc=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.