From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Bug 1087974 <1087974@bugs.launchpad.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Bug 1087974] Re: [regression] vnc tight png produces garbled output
Date: Tue, 11 Dec 2012 10:15:51 +0100 [thread overview]
Message-ID: <50C6F9C7.5010608@redhat.com> (raw)
In-Reply-To: <20121211085711.GC23720@stefanha-thinkpad.muc.redhat.com>
On 12/11/12 09:57, Stefan Hajnoczi wrote:
> On Mon, Dec 10, 2012 at 03:54:58PM -0000, Tim Hardeck wrote:
>> 47683d669f993308c2b84bed4ce64aafb5d7ced4 is the first bad commit
>> commit 47683d669f993308c2b84bed4ce64aafb5d7ced4
>> Author: Gerd Hoffmann <kraxel@redhat.com>
>> Date: Thu Oct 11 12:04:33 2012 +0200
>>
>> pixman/vnc: remove rgb_prepare_row* functions
>>
>> Let pixman do it instead.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>>
>> :040000 040000 653d58e66bf3a2d8240b2f9176979c44ccd720e1
>> 6b6e367a8522cb58b42ad8f204387a354d3b3d00 M ui
>>
>>
>> Just reverting this particular commit isn't enough thou but it is connected.
>
> This suggests the conversion to pixman has introduced the bug.
Quite possible. I've tested tight via 'vncviewer
PreferredEncoding=Tight', but that doesn't force png, so there is a
chance for issues I havn't seen.
> Tim: can you provide steps to reproduce the bug?
That will certainly help fixing.
Also: How garbled? Totally messed up? Just colors wrong? Any other
visible pattern?
cheers,
Gerd
next prev parent reply other threads:[~2012-12-11 9:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 11:46 [Qemu-devel] [Bug 1087974] [NEW] [regression] vnc tight png produces garbled output Tim Hardeck
2012-12-10 14:23 ` Stefan Hajnoczi
2012-12-10 15:54 ` [Qemu-devel] [Bug 1087974] " Tim Hardeck
2012-12-11 8:57 ` Stefan Hajnoczi
2012-12-11 9:15 ` Gerd Hoffmann [this message]
2012-12-11 10:09 ` Tim Hardeck
2012-12-11 14:50 ` Gerd Hoffmann
2012-12-11 11:11 ` Tim Hardeck
2012-12-11 15:50 ` Tim Hardeck
2012-12-14 12:29 ` Tim Hardeck
2016-11-21 15:45 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C6F9C7.5010608@redhat.com \
--to=kraxel@redhat.com \
--cc=1087974@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.