All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V7 09/10] Use QemuOpts support in block layer
Date: Tue, 11 Dec 2012 16:52:47 +0100	[thread overview]
Message-ID: <50C756CF.8020602@redhat.com> (raw)
In-Reply-To: <1354776447-12041-10-git-send-email-wdongxu@linux.vnet.ibm.com>

Am 06.12.2012 07:47, schrieb Dong Xu Wang:
> This patch will use QemuOpts related functions in block layer, add
> a member bdrv_create_options to BlockDriver struct, it will return
> a QemuOptsList pointer, which includes the image format's create
> options.
> 
> And create options's primary consumer is block creating related functions,
> so modify them together.
> 
> This patch also define a macro called STRINGIZER, it is used to convert
> number to string.
> 
> v6->v7:
> 1) use osdep.h:stringify(), not redefining new macro.
> 2) preserve TODO comment.
> 3) fix typo: BLOCK_OPT_ENCRYPT->BLOCK_OPT_STATIC.
> 4) initialize disk_type even when opts is NULL.
> 
> v5->v6:
> 1) judge if opts == NULL in block layer create functions.
> 2) use bdrv_create_file(filename, NULL) in qcow_create and cow_create funtion.
> 3) made more readable while using qemu_opt_get_number.
> 
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>

This doesn't apply any more and needs a rebase.

Kevin

  reply	other threads:[~2012-12-11 15:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06  6:47 [Qemu-devel] [PATCH V7 00/10] replace QEMUOptionParameter with QemuOpts parser Dong Xu Wang
2012-12-06  6:47 ` [Qemu-devel] [PATCH V7 01/10] qemu-option: opt_set(): split it up into more functions Dong Xu Wang
2012-12-06  6:47 ` [Qemu-devel] [PATCH V7 02/10] qemu-option: qemu_opts_validate(): fix duplicated code Dong Xu Wang
2012-12-06  6:47 ` [Qemu-devel] [PATCH V7 03/10] qemu-option: qemu_opt_set_bool(): fix code duplication Dong Xu Wang
2012-12-06  6:47 ` [Qemu-devel] [PATCH V7 04/10] introduce qemu_opts_create_nofail function Dong Xu Wang
2012-12-06  6:47 ` [Qemu-devel] [PATCH V7 05/10] use qemu_opts_create_nofail Dong Xu Wang
2012-12-06  6:47 ` [Qemu-devel] [PATCH V7 06/10] create new function: qemu_opt_set_number Dong Xu Wang
2012-12-06  6:47 ` [Qemu-devel] [PATCH V7 07/10] add def_print_str and use it in qemu_opts_print Dong Xu Wang
2012-12-11 15:51   ` Kevin Wolf
2012-12-06  6:47 ` [Qemu-devel] [PATCH V7 08/10] Create four opts list related functions Dong Xu Wang
2012-12-06  6:47 ` [Qemu-devel] [PATCH V7 09/10] Use QemuOpts support in block layer Dong Xu Wang
2012-12-11 15:52   ` Kevin Wolf [this message]
2012-12-06  6:47 ` [Qemu-devel] [PATCH V7 10/10] remove QEMUOptionParameter related functions and struct Dong Xu Wang
2012-12-11  8:43 ` [Qemu-devel] [PATCH V7 00/10] replace QEMUOptionParameter with QemuOpts parser Stefan Hajnoczi
2012-12-11 15:57 ` Kevin Wolf
2012-12-12  7:06   ` Dong Xu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C756CF.8020602@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wdongxu@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.