All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Christian Bendele <Christian.Bendele@gmx.net>
Cc: linux-can@vger.kernel.org
Subject: Re: pch_can probable bug
Date: Tue, 11 Dec 2012 17:22:09 +0100	[thread overview]
Message-ID: <50C75DB1.3080703@grandegger.com> (raw)
In-Reply-To: <loom.20121211T165553-739@post.gmane.org>

Hi Christian,

On 12/11/2012 05:08 PM, Christian Bendele wrote:
> Well, I just found the most recent patch to the generic c_can driver on this
> list. I had only checked with Kernel 3.7rcSomething before and it didn't seem to
> support the intel eg20t. I failed to check if there was a more recent patch
> available and if that supported the intel chip. I'm really sorry for that.
> 
> I will try if that patch works for me tomorrow, since unfortunatelly my working
> day is almost at its end and I don't have the hardware at home. However, cursery
> skimming the code of c_can.c, c_can_do_rx_poll() it seems to me as if it does
> the same thing here:
> 
> 
> 			if (msg_ctrl_save & IF_MCONT_EOB)
> 				return num_rx_pkts;

Just a quick answer. We know that the pch_can and also the c_can driver
does have issues with tx and rx. Races, out-of-order-receptions, etc. I
have sent patches for the C_CAN drivers to support the PCH as well. But
still the RX handling needs to be improved to avoid out-of-order
reception at high message input rate. I will tell more later today.

Wolfgang.


  reply	other threads:[~2012-12-11 16:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11 15:43 pch_can probable bug Christian Bendele
2012-12-11 16:08 ` Christian Bendele
2012-12-11 16:22   ` Wolfgang Grandegger [this message]
2012-12-11 22:05 ` Wolfgang Grandegger
2012-12-17 13:21   ` Christian Bendele
2012-12-17 14:50     ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C75DB1.3080703@grandegger.com \
    --to=wg@grandegger.com \
    --cc=Christian.Bendele@gmx.net \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.