From: Saul Wold <sgw@linux.intel.com>
To: "Shakeel, Muhammad" <muhammad_shakeel@mentor.com>
Cc: Christopher Larson <chris_larson@mentor.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] wireless-tools: Remove QA warning: No GNU_HASH in the elf binary
Date: Tue, 11 Dec 2012 10:48:42 -0800 [thread overview]
Message-ID: <50C7800A.1010502@linux.intel.com> (raw)
In-Reply-To: <1355220496-8878-1-git-send-email-muhammad_shakeel@mentor.com>
On 12/11/2012 02:08 AM, Shakeel, Muhammad wrote:
> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>
> Handle LDFLAGS properly in the Makefile to remove warning:
> QA Issue: No GNU_HASH in the elf binary
>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> ---
> .../wireless-tools/wireless-tools/ldflags.patch | 15 +++++++++++++++
> .../wireless-tools/wireless-tools_29.bb | 3 ++-
> 2 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/wireless-tools/wireless-tools/ldflags.patch b/meta/recipes-connectivity/wireless-tools/wireless-tools/ldflags.patch
> new file mode 100644
> index 0000000..84144ac
> --- /dev/null
> +++ b/meta/recipes-connectivity/wireless-tools/wireless-tools/ldflags.patch
> @@ -0,0 +1,15 @@
No patch header
Please add a Signed-off-by: and Upstream-Status: tags
Thanks
Sau!
> +---
> + Makefile | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +--- wireless_tools.29.orig/Makefile
> ++++ wireless_tools.29/Makefile
> +@@ -144,7 +144,7 @@ wireless.h:
> +
> + # Compilation of the dynamic library
> + $(DYNAMIC): $(OBJS:.o=.so)
> +- $(CC) -shared -o $@ -Wl,-soname,$@ $(STRIPFLAGS) $(LIBS) -lc $^
> ++ $(CC) -shared -o $@ -Wl,-soname,$@ $(LDFLAGS) $(STRIPFLAGS) $(LIBS) -lc $^
> +
> + # Compilation of the static library
> + $(STATIC): $(OBJS:.o=.so)
> diff --git a/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb b/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
> index 209f29a..b4d34bb 100644
> --- a/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
> +++ b/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
> @@ -14,7 +14,8 @@ SRC_URI = "http://www.hpl.hp.com/personal/Jean_Tourrilhes/Linux/wireless_tools.2
> file://man.patch \
> file://wireless-tools.if-pre-up \
> file://zzz-wireless.if-pre-up \
> - file://avoid_strip.patch"
> + file://avoid_strip.patch \
> + file://ldflags.patch"
>
> SRC_URI[md5sum] = "e06c222e186f7cc013fd272d023710cb"
> SRC_URI[sha256sum] = "6fb80935fe208538131ce2c4178221bab1078a1656306bce8909c19887e2e5a1"
>
prev parent reply other threads:[~2012-12-11 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 10:08 [PATCH] wireless-tools: Remove QA warning: No GNU_HASH in the elf binary Shakeel, Muhammad
2012-12-11 18:48 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C7800A.1010502@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=chris_larson@mentor.com \
--cc=muhammad_shakeel@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.