From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Tue, 11 Dec 2012 14:11:48 -0700 Subject: [PATCH 1/2] pinctrl: add sleep mode management for hogs In-Reply-To: <1355234393-17368-1-git-send-email-linus.walleij@stericsson.com> References: <1355234393-17368-1-git-send-email-linus.walleij@stericsson.com> Message-ID: <50C7A194.7070102@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/11/2012 06:59 AM, Linus Walleij wrote: > From: Julien Delacou > > This fix allows handling sleep mode for hogged > pins in pinctrl. It provides functions to set pins > to sleep/default configurations according to their > current state from the individual pinctrl drivers. > diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h > +extern int pinctrl_force_sleep(struct pinctrl_dev *pctldev); > +extern int pinctrl_force_default(struct pinctrl_dev *pctldev); Since I assume those function are only supposed to be used by pinctrl drivers themselves, should the prototypes go into drivers/pinctrl/core.h or similar, rather than something in include/linux/pinctrl? Oh, and don't you need EXPORT_SYMBOL in case the pinctrl driver is a module? Aside from that, Reviewed-by: Stephen Warren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754037Ab2LKVLx (ORCPT ); Tue, 11 Dec 2012 16:11:53 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:56304 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753389Ab2LKVLw (ORCPT ); Tue, 11 Dec 2012 16:11:52 -0500 Message-ID: <50C7A194.7070102@wwwdotorg.org> Date: Tue, 11 Dec 2012 14:11:48 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Linus Walleij CC: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Warren , Anmar Oueja , Julien Delacou , Linus Walleij Subject: Re: [PATCH 1/2] pinctrl: add sleep mode management for hogs References: <1355234393-17368-1-git-send-email-linus.walleij@stericsson.com> In-Reply-To: <1355234393-17368-1-git-send-email-linus.walleij@stericsson.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/2012 06:59 AM, Linus Walleij wrote: > From: Julien Delacou > > This fix allows handling sleep mode for hogged > pins in pinctrl. It provides functions to set pins > to sleep/default configurations according to their > current state from the individual pinctrl drivers. > diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h > +extern int pinctrl_force_sleep(struct pinctrl_dev *pctldev); > +extern int pinctrl_force_default(struct pinctrl_dev *pctldev); Since I assume those function are only supposed to be used by pinctrl drivers themselves, should the prototypes go into drivers/pinctrl/core.h or similar, rather than something in include/linux/pinctrl? Oh, and don't you need EXPORT_SYMBOL in case the pinctrl driver is a module? Aside from that, Reviewed-by: Stephen Warren