From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TijBg-0002VU-Sp for qemu-devel@nongnu.org; Wed, 12 Dec 2012 05:05:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TijBX-0006OG-7V for qemu-devel@nongnu.org; Wed, 12 Dec 2012 05:05:12 -0500 Received: from cantor2.suse.de ([195.135.220.15]:55082 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TijBW-00063g-U2 for qemu-devel@nongnu.org; Wed, 12 Dec 2012 05:05:03 -0500 Message-ID: <50C856A0.5060902@suse.de> Date: Wed, 12 Dec 2012 11:04:16 +0100 From: Tim Hardeck MIME-Version: 1.0 References: <1354892195-18332-1-git-send-email-thardeck@suse.de> <1354892195-18332-3-git-send-email-thardeck@suse.de> <20121211100409.GD796@stefanha-thinkpad.muc.redhat.com> In-Reply-To: <20121211100409.GD796@stefanha-thinkpad.muc.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig10B30BA2DF58D2A92251D420" Subject: Re: [Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: aliguori@us.ibm.com, github@martintribe.org, qemu-devel@nongnu.org, alevy@redhat.com, kraxel@redhat.com, corentin.chary@gmail.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig10B30BA2DF58D2A92251D420 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 12/11/2012 11:04 AM, Stefan Hajnoczi wrote: > On Fri, Dec 07, 2012 at 03:56:34PM +0100, Tim Hardeck wrote: >=20 > Thanks for addressing my review comments. >=20 >> @@ -1328,13 +1358,14 @@ void vnc_client_read(void *opaque) >> =20 >> void vnc_write(VncState *vs, const void *data, size_t len) >> { >> - buffer_reserve(&vs->output, len); >> + buffer_reserve(&vs->output, len); >> =20 >> - if (vs->csock !=3D -1 && buffer_empty(&vs->output)) { >> - qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read, vnc_cl= ient_write, vs); >> - } >> + if (vs->csock !=3D -1 && buffer_empty(&vs->output)) { >> + qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read, >> + vnc_client_write, vs); >> + } >> =20 >> - buffer_append(&vs->output, data, len); >> + buffer_append(&vs->output, data, len); >=20 > QEMU uses 4 spaces for indentation. I don't know how I missed that, probably during the removal of the previous parts, but `scripts/checkpatch.pl` didn't complain either. Is the rest of the patchset fine? Regards Tim --=20 SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer, HRB 16746 (AG N=FCrnberg) Maxfeldstr. 5, 90409 N=FCrnberg, Germany T: +49 (0) 911 74053-0 F: +49 (0) 911 74053-483 http://www.suse.de/ --------------enig10B30BA2DF58D2A92251D420 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQEcBAEBAgAGBQJQyFahAAoJENur/L6EMd67UqAIAKVmbMOjm00iprywEIuRhFV6 wPwlapHZwAAVVlAfFahefCUGsywtgeQdG3XbUBbJs5lWZrqUbKJAAoRb8JFfzIvp Mg+pjN7f0pGIs88SIDms0ujON1ftC/BWCF5bWe6GIo/f6HKbWd32Uf4QuaGKwChe f5TWh/lEqmZCaiDobBn9dkkUgj2MoUgCW6Cm1tw6Xavk/B+q1rHbZyCm32lfUw9L niWc6HgoSGp3XTZ+rUAZ9lA+FvnLv0+LHcOyCeykfKiUVEhK+DFeimOU9LmaumBt ivbNKwqUjNJ1tVuIbrvRZ9gNdQwakkZ/lPCTkDgtqfapM96DXRO31v7BmnVq6aM= =DwYK -----END PGP SIGNATURE----- --------------enig10B30BA2DF58D2A92251D420--