All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH resend 2/2] net/macb: Add arch specific routine to get mdio control
Date: Wed, 12 Dec 2012 12:07:54 +0100	[thread overview]
Message-ID: <50C8658A.1060706@denx.de> (raw)
In-Reply-To: <8ff845e533e9d174c6fe70cc8a6be5ec753bd071.1354777675.git.vipin.kumar@st.com>

On 12/06/2012 08:10 AM, Vipin Kumar wrote:
> From: Shiraz Hashim <shiraz.hashim@st.com>
> 
> SPEAr310 and SPEAr320 Ethernet interfaces share same MDIO lines to control their
> respective phys. Currently their is a fixed configuration in which only a
> particular MAC can use the MDIO lines.

"there is" instead of "their is"

> Call an arch specific function to take control of specific mdio lines at
> runtime.
> 
> Signed-off-by: Shiraz Hashim <shiraz.hashim@st.com>
> Signed-off-by: Vipin Kumar <vipin.kumar@st.com>
> ---
>  drivers/net/macb.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 8bacbda..45fbbd7 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -163,6 +163,13 @@ static u16 macb_mdio_read(struct macb_device *macb, u8 reg)
>  	return MACB_BFEXT(DATA, frame);
>  }
>  
> +static void __def_arch_get_mdio_control(const char *name)
> +{
> +	return;
> +}
> +int arch_get_mdio_control(const char *name)
> +	__attribute__((weak, alias("__def_arch_get_mdio_control")));

__weak from linux/compiler.h please

Otherwise:

Acked-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

  parent reply	other threads:[~2012-12-12 11:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06  7:10 [U-Boot] [PATCH resend 1/2] net/designware: Do not select MIIPORT for RGMII interface Vipin Kumar
2012-12-06  7:10 ` [U-Boot] [PATCH resend 2/2] net/macb: Add arch specific routine to get mdio control Vipin Kumar
2012-12-12 10:37   ` Vipin Kumar
2012-12-12 11:07   ` Stefan Roese [this message]
2012-12-12 11:13     ` Vipin Kumar
2012-12-12 10:01 ` [U-Boot] [PATCH resend 1/2] net/designware: Do not select MIIPORT for RGMII interface Vipin Kumar
2012-12-12 10:09 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C8658A.1060706@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.