All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed
Date: Wed, 12 Dec 2012 15:01:55 +0100	[thread overview]
Message-ID: <50C88E53.4080200@redhat.com> (raw)
In-Reply-To: <20121212135050.GC16270@stefanha-thinkpad.redhat.com>

Il 12/12/2012 14:50, Stefan Hajnoczi ha scritto:
> VirtIOBlock->rq can trigger the assertion.
> 
> IIUC hw/virtio-blk.c may handle I/O errors by keeping the request
> pending and on a list (->rq).  This allows the user to restart them
> after, for example, adding more space to the host file system containing
> the disk image file.
> 
> We keep a list of failed requests and we migrate this list.  So I think
> inuse != 0 when migrating with pending failed I/O requests.

Same for virtio-scsi.  Each request in that case is sent as part of the
SCSIDevice that it refers to, via callbacks in SCSIBusInfo.

Paolo

  reply	other threads:[~2012-12-12 14:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-12 10:51 [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed Michael S. Tsirkin
2012-12-12 13:50 ` Stefan Hajnoczi
2012-12-12 14:01   ` Paolo Bonzini [this message]
2012-12-12 14:30     ` Michael S. Tsirkin
2012-12-12 14:36       ` Paolo Bonzini
2012-12-12 14:47         ` Michael S. Tsirkin
2012-12-12 15:01           ` Paolo Bonzini
2012-12-12 15:25             ` Michael S. Tsirkin
2012-12-12 15:52               ` Paolo Bonzini
2012-12-12 16:37                 ` Michael S. Tsirkin
2012-12-12 16:51                   ` Paolo Bonzini
2012-12-12 17:14                     ` Michael S. Tsirkin
2012-12-12 17:39                       ` Paolo Bonzini
2012-12-12 19:23                         ` Michael S. Tsirkin
2012-12-12 21:00                           ` Paolo Bonzini
2012-12-12 21:19                             ` Michael S. Tsirkin
2012-12-12 21:33                               ` Anthony Liguori
2012-12-12 21:51                                 ` Michael S. Tsirkin
2012-12-14  1:06                                 ` Rusty Russell
2012-12-14  7:51                                   ` Paolo Bonzini
2012-12-16 20:36                                     ` Anthony Liguori
2012-12-13  7:39                               ` Paolo Bonzini
2012-12-13 10:48                   ` Kevin Wolf
2012-12-16 16:14                     ` Michael S. Tsirkin
2012-12-12 14:26   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C88E53.4080200@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcorp.com.au \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.