Re: [PATCH] OF: MIPS: sead3: Implement OF support.

[Florian Fainelli <florian@openwrt.org>]

Le 12/12/12 15:53, Lars-Peter Clausen a écrit :
> On 12/12/2012 03:29 PM, Florian Fainelli wrote:
>> Hello Steven,
>>
>> Le 12/07/12 06:14, Steven J. Hill a écrit :
>> [snip]
>>
>>> +/ {
>>> +    #address-cells = <1>;
>>> +    #size-cells = <1>;
>>> +    compatible = "mips,sead-3";
>>> +
>>> +    cpus {
>>> +        cpu@0 {
>>> +            compatible = "mips,mips14Kc,mips14KEc";
>>> +        };
>> You probably want this the other way around:
>>
>> mips14KEc,mips14Kc,mips
>>
>> you should always have the left-most string being the most descriptive about
>> the hardware and the last one being the less descriptive and thus less
>> "specializing" in order to be backward compatible.
> This is one compatible string though, what you describe is for when use
> multiple compatible string. E.g.
> compatible = "mips14KEc", "mips14Kc", "mips";
>
> The "mips" in Stevens patch is probably the vendor prefix. Maybe a more
> correct compatible would be.
>
> compatible = "mips,mips14KEc", "mips,mips14Kc";

Right, this should be the proper compatible string. Steven's patch does 
not make any use of this compatible string right now anyway.

>
> But in anyway the patch should also add documentation under
> Documentation/devicetree/bindings describing the binding.
>
Obviously
--
Florian