From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Tioa5-0001g8-OF
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:50:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TioZz-0003Ng-PN
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:50:45 -0500
Received: from cantor2.suse.de ([195.135.220.15]:42975 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TioZz-0003NR-Jd
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:50:39 -0500
Message-ID: <50C8A7CA.8090904@suse.de>
Date: Wed, 12 Dec 2012 16:50:34 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1355317734-55761-1-git-send-email-jfrei@linux.vnet.ibm.com>
	<1355317734-55761-4-git-send-email-jfrei@linux.vnet.ibm.com>
	<50C88BED.6000000@suse.de> <50C89D30.4020508@linux.vnet.ibm.com>
In-Reply-To: <50C89D30.4020508@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP
	query-cpu-definitions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
Cc: Heinz Graalfs <graalfs@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Einar Lueck <elelueck@linux.vnet.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On 12/12/2012 04:05 PM, Viktor Mihajlovski wrote:
> On 12/12/2012 02:51 PM, Andreas F=E4rber wrote:
>>> +    (*cpu_fprintf)(f, "s390 %16s\n", "[host]");
>>
>> Note that the square-bracket notation was specific to x86 when it
>> distinguished between built-in and config-based models.
>>
> OK, since libvirt capable of dealing with s390 cpu models will
> never see this, we can change it any way that is wanted.
> So, host without brackets?
>> "host" only makes sense for KVM, not for TCG. So we would need one oth=
er
>> placeholder model for libvirt.
> see my reply to Alex' comment: the placeholder name must be chosen
> carefully, i.e. future-proof

Yeah, it's perfectly fine for me to ignore the model name in the code=20
today (as we do iirc) and only add the host target for starters. Though=20
that one should do a kvm_enabled() check.


Alex