From: Arjan van de Ven <arjan at linux.intel.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] cpufreq: only try to open files under cpuX
Date: Wed, 12 Dec 2012 10:21:43 -0800 [thread overview]
Message-ID: <50C8CB37.3040406@linux.intel.com> (raw)
In-Reply-To: 1308422363.328395.1355335523877.JavaMail.root@redhat.com
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On 12/12/2012 10:05 AM, Jaroslav Skarvada wrote:
> -
>> Hello,
>> thanks for your patch. however, I'm afraid it does not fix all the
>> cases. looking at src/tuning/cpufreq.cpp we
>> have several more places with exactly the same cpuX detection --
>> ::toggle*().
>>
> NP, I will try to fix them all, I will post new version of the patch soon.
>
>> could you also please remove 'strlen(dirent->d_name) < 4', looks loke
>> a small overhead there.
>>
> Right :)
it makes sense to clean this up indeed
now, I'm still wanting to rewrite the whole frequency side... it's not great code right now,
and makes assumptions that aren't going to be true going forward.
but until that's done.. by all means lets do improvements like this to the existing code.
next reply other threads:[~2012-12-12 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 18:21 Arjan van de Ven [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-13 18:21 [Powertop] [PATCH] cpufreq: only try to open files under cpuX Sergey Senozhatsky
2012-12-13 14:43 Jaroslav Skarvada
2012-12-12 18:05 Jaroslav Skarvada
2012-12-12 17:56 Sergey Senozhatsky
2012-12-12 16:16
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C8CB37.3040406@linux.intel.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.