From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH] cpuidle - remove the power_specified field in the driver Date: Wed, 12 Dec 2012 21:00:53 +0100 Message-ID: <50C8E275.9050308@linaro.org> References: <1355325801-1317-1-git-send-email-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:49164 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754985Ab2LLUBD (ORCPT ); Wed, 12 Dec 2012 15:01:03 -0500 Received: by mail-bk0-f46.google.com with SMTP id q16so618386bkw.19 for ; Wed, 12 Dec 2012 12:01:01 -0800 (PST) In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Julius Werner Cc: "Rafael J. Wysocki" , Francesco Lavra , linux-pm@vger.kernel.org, Deepthi Dharwar , Trinabh Gupta , Lists Linaro-dev , len.brown@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Sameer Nanda On 12/12/2012 07:50 PM, Julius Werner wrote: > Thanks again for making this happen, Daniel. I like this version, > except for the small nitpick that I still think it would make sense t= o > also turn the loop in menu.c around. How about something like this: >=20 > for (i =3D drv->state_count - 1; i >=3D CPUIDLE_DRIVER_STATE_S= TART; i++) { > struct cpuidle_state *s =3D &drv->states[i]; > if (!s->disable && s->exit_latency <=3D latency_req &= & > s->target_residency <=3D data->predicted_us && > s->exit_latency * multiplier <=3D data->predicted= _us) { > data->last_state_idx =3D i; > data->exit_us =3D s->exit_latency; > break; > } > } Actually I was planning to do that in a separate patch. --=20 Linaro.org =E2=94=82 Open source software for= ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog