From: Douglas Gilbert <dgilbert@interlog.com>
To: "Ewan D. Milne" <emilne@redhat.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] [SCSI] scsi_debug: fix deadlock on module unload, also complete queued commands
Date: Thu, 13 Dec 2012 07:21:17 +1100 [thread overview]
Message-ID: <50C8E73D.4070908@interlog.com> (raw)
In-Reply-To: <1355331647-6604-1-git-send-email-emilne@redhat.com>
On 12-12-13 04:00 AM, Ewan D. Milne wrote:
> From: "Ewan D. Milne" <emilne@redhat.com>
>
> The module unload path in scsi_debug was calling del_timer_sync() with the
> queued_arr_lock held. The timer_intr_handler() function also takes this lock,
> so if it executes as the timer is being removed, the kernel would deadlock.
>
> Also changed to complete all queued commands if scsi_debug is unloaded instead
> of discarding them, because the requests would eventually timeout after the
> module was gone.
>
> Signed-off-by: Ewan D. Milne <emilne@redhat.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
prev parent reply other threads:[~2012-12-12 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 17:00 [PATCH] [SCSI] scsi_debug: fix deadlock on module unload, also complete queued commands Ewan D. Milne
2012-12-12 20:21 ` Douglas Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C8E73D.4070908@interlog.com \
--to=dgilbert@interlog.com \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.