From: Michal Marek <mmarek@suse.cz>
To: Adam Lee <adam8157@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 4/5] ktest: Fix breakage from change of oldnoconfig to olddefconfig
Date: Thu, 13 Dec 2012 09:51:44 +0100 [thread overview]
Message-ID: <50C99720.20402@suse.cz> (raw)
In-Reply-To: <20121213030602.GA10129@adam-station.nay.redhat.com>
On 13.12.2012 04:06, Adam Lee wrote:
> On Wed, Dec 12, 2012 at 05:14:41PM -0500, Steven Rostedt wrote:
>> From: Steven Rostedt <srostedt@redhat.com>
>>
>> Commit fb16d891 "kconfig: replace 'oldnoconfig' with 'olddefconfig', and
>> keep the old name", changed ktest's default config update from
>> oldnoconfig to olddefconfig without adding oldnoconfig as a backup.
>> The make oldnoconfig works much better than its backup of:
>> yes '' | make oldconfig
>>
>> But due to this change, and the fact that ktest is used to build lots of
>> older kernels (and for bisects), it forgoes the oldnoconfig completely.
>>
>> Cc: Adam Lee <adam8157@gmail.com>
>> Cc: Michal Marek <mmarek@suse.cz>
>> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> This makes sense, we should provide a backup for older kernels. Sorry
> for not noticing the breakage.
>
> Acked-by: Adam Lee <adam8157@gmail.com>
Acked-by: Michal Marek <mmarek@suse.cz>
Michal
next prev parent reply other threads:[~2012-12-13 8:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 22:14 [PATCH 0/5] [GIT PULL] ktest: fixes and updated for new boot loaders Steven Rostedt
2012-12-12 22:14 ` [PATCH 1/5] ktest: Add support for grub2 Steven Rostedt
2012-12-12 22:14 ` [PATCH 2/5] ktest: Sync before reboot Steven Rostedt
2012-12-12 22:14 ` [PATCH 3/5] ktest: Add native support for syslinux boot loader Steven Rostedt
2012-12-12 22:14 ` [PATCH 4/5] ktest: Fix breakage from change of oldnoconfig to olddefconfig Steven Rostedt
2012-12-13 3:06 ` Adam Lee
2012-12-13 8:51 ` Michal Marek [this message]
2012-12-12 22:14 ` [PATCH 5/5] ktest: Test if target machine is up before install Steven Rostedt
2012-12-12 23:47 ` [PATCH 0/5] [GIT PULL] ktest: fixes and updated for new boot loaders Stephen Rothwell
2012-12-13 0:29 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C99720.20402@suse.cz \
--to=mmarek@suse.cz \
--cc=adam8157@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.