From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Tj6L3-0005sG-As
	for qemu-devel@nongnu.org; Thu, 13 Dec 2012 05:48:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Tj6L1-0003rI-4e
	for qemu-devel@nongnu.org; Thu, 13 Dec 2012 05:48:25 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37559)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Tj6L0-0003rE-SF
	for qemu-devel@nongnu.org; Thu, 13 Dec 2012 05:48:23 -0500
Message-ID: <50C9B271.2020906@redhat.com>
Date: Thu, 13 Dec 2012 11:48:17 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <20121212105101.GA6461@redhat.com>
	<20121212135050.GC16270@stefanha-thinkpad.redhat.com>
	<50C88E53.4080200@redhat.com> <20121212143038.GD15555@redhat.com>
	<50C8965A.7020004@redhat.com> <20121212144758.GF15555@redhat.com>
	<50C89C47.7040108@redhat.com> <20121212152508.GB16750@redhat.com>
	<50C8A855.4050607@redhat.com> <20121212163713.GD17446@redhat.com>
In-Reply-To: <20121212163713.GD17446@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding
 buffers are flushed
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@gmail.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

Am 12.12.2012 17:37, schrieb Michael S. Tsirkin:
> On Wed, Dec 12, 2012 at 04:52:53PM +0100, Paolo Bonzini wrote:
>> Il 12/12/2012 16:25, Michael S. Tsirkin ha scritto:
>>> On Wed, Dec 12, 2012 at 04:01:27PM +0100, Paolo Bonzini wrote:
>>>> Il 12/12/2012 15:47, Michael S. Tsirkin ha scritto:
>>>>> As step 1, I think we should just complete all outstanding
>>>>> requests when VM stops.
>>>>>
>>>>> Yes it means you can't do the retry hack after migration
>>>>> but this is hardly common scenario.
>>>>
>>>> I disagree...
>>>
>>> Disagree with what? You are saying it's common?
>>
>> It's not common, but you cannot block migration because you have an I/O
>> error.  Solving the error may involve migrating the guests away from
>> that host.
>>
>> Paolo
> 
> No, you should complete with error.

Just to confirm that this isn't possible: rerror/werror=stop is a
supported feature, and I do get bug reports when it breaks (including
migration while the VM is stopped for an I/O error).

Makes it common enough that breaking it is definitely not an option, right?

Kevin