From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ns16550: allow UART address to be set dynamically
Date: Thu, 13 Dec 2012 08:11:55 -0500 [thread overview]
Message-ID: <50C9D41B.7010800@ti.com> (raw)
In-Reply-To: <20121213102711.6585C20120D@gemini.denx.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/13/12 05:27, Wolfgang Denk wrote:
> Dear Stephen Warren,
>
> In message
> <1355354590-10023-1-git-send-email-swarren@wwwdotorg.org> you
> wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> A single U-Boot binary may support multiple very similar boards.
>> These boards may use different UARTs for the main debug console.
>> Hence, it is impossible to #define CONFIG_SYS_NS16550_COM1 to
>> some static UART address, since the true value may only be
>> determined at run-time, after identifying the actual hardware.
>> Provide an API for boards to call to set the actual address of
>> the UART, e.g. from spl_board_init() or board_early_init_f().
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> As is, this is just adding dead code.
>
> Where would the device addresses come from - out of the device
> tree?
Board specific knowledge. I'd be tempted to add UART3 (iirc) into the
am335x_evm default build so that we can support the Industrial DevKit
variant out of the box, rather than needing one of the other _uartN
builds. We can tell which board we're on at run-time already.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQIcBAEBAgAGBQJQydQbAAoJENk4IS6UOR1WLpsP/3TsidcGHLMQoqyktG/qtzFr
LmIT7wfNomLsl7xmTrO0B4GwvpsH6OucW90z6HrL0qvH3IhZ2FohUcyWwWNNo2KZ
1gEFSMPbwZt3htrFE/fhHT8n+Fo/eq2hY32WmxnWV8XS46+FL348FHNxEeIiQN1p
1MwxmJmEGBqAtBdC7t2JIoHsQqd+txDs6R5xpm8f2S2zenJFkbp45FwDeQrn4Bu/
XVagwL4R/L21bPt/I90RdkRe5lt7ukQwoG1+HgaEjoCdiCol9p6bjBwWll+NXb9/
ouk+7rYEncjxn+/W9XB7ojeBwOMxQbreg4JJFikn41g5XOkLIe+l0n2/j1jWVSOO
u3ORXxOr1icMRY9BgUkLuKlhtONQX5IPz8t5F4N8tyhsGFSxs6kuX2NKo+Oy25B5
cidh43exx8VkHqInsq7ZFlll/Xdk7PD16iY7qoZh8BE6KzdbchBeZX2bCn3NiOIS
RtfVXrng58PaetHyzjsfcu1HDaaGez8vztabVUF4PECQmnV7hz2Vw25HqoK9un/L
Snl9uPNBELKA7DesPRMx0LaGwDkx4UBecvX2nWm+krkihvbdalmnawNbIWv9WNSt
OG3w+r/Ka68t2vFVTbIBVK7IVeDe/dISLpQ7R/MiVIzJDnD9EFJUQpaKxWp54PKF
ZV4bb59FxRxBpkO5eA1L
=QfiQ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-12-13 13:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 23:23 [U-Boot] [PATCH] ns16550: allow UART address to be set dynamically Stephen Warren
2012-12-12 23:38 ` Simon Glass
2012-12-12 23:52 ` Stephen Warren
2012-12-13 0:38 ` Simon Glass
2012-12-13 10:29 ` Wolfgang Denk
2012-12-13 18:17 ` Stephen Warren
2012-12-13 20:36 ` Wolfgang Denk
2012-12-13 20:45 ` Stephen Warren
2012-12-13 20:53 ` Tom Rini
2012-12-13 21:07 ` Stephen Warren
2012-12-13 21:51 ` Simon Glass
2012-12-14 20:40 ` Tom Rini
2012-12-14 21:14 ` Simon Glass
2012-12-14 22:03 ` Stephen Warren
2012-12-14 22:22 ` Simon Glass
2012-12-14 22:45 ` Stephen Warren
2012-12-17 21:09 ` Tom Rini
2012-12-17 22:24 ` Stephen Warren
2012-12-17 22:37 ` Wolfgang Denk
2012-12-17 22:58 ` Stephen Warren
2012-12-18 6:39 ` Wolfgang Denk
2012-12-18 16:37 ` Stephen Warren
2012-12-18 19:15 ` Simon Glass
2012-12-17 21:09 ` Tom Rini
2012-12-14 22:35 ` Wolfgang Denk
2012-12-14 21:52 ` Stephen Warren
2012-12-14 22:31 ` Wolfgang Denk
2012-12-14 22:26 ` Wolfgang Denk
2012-12-14 23:16 ` Graeme Russ
2012-12-15 0:32 ` Wolfgang Denk
2012-12-15 1:32 ` Graeme Russ
2012-12-15 7:30 ` Wolfgang Denk
2012-12-15 9:53 ` Graeme Russ
2012-12-17 21:04 ` Tom Rini
2012-12-13 23:11 ` Wolfgang Denk
2012-12-13 23:26 ` Stephen Warren
2012-12-13 10:27 ` Wolfgang Denk
2012-12-13 13:11 ` Tom Rini [this message]
2012-12-13 14:22 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C9D41B.7010800@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.