From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Damien Zammit <damien.zammit@gmail.com>,
Daniel Mack <zonque@gmail.com>
Subject: Re: sound: usb-audio: full capture/playback/spdif support for Digidesign Mbox 2
Date: Thu, 13 Dec 2012 16:29:35 +0100 [thread overview]
Message-ID: <50C9F45F.3010806@ladisch.de> (raw)
In-Reply-To: <s5hvcc6yp4w.wl%tiwai@suse.de>
Takashi Iwai wrote:
> Damien Zammit wrote:
>> + case QUIRK_MIDI_MBOX2:
>> + /* Digidesign Mbox 2 uses MIDIMAN MIDI protocol */
>> + umidi->usb_protocol_ops = &snd_usbmidi_midiman_ops;
>> + err = snd_usbmidi_detect_per_port_endpoints(umidi, endpoints);
>> + break;
>
> If the quirk handling is as same as QUIRK_MIDI_MIDIMAN, can't we just
> reuse it instead of adding yet a new type?
The endpoint detection is different; that comment applies only to the
next single line.
But while technically correct, the comment is superfluous because it
doesn't say anything that isn't obvious from the code.
Regards,
Clemens
next prev parent reply other threads:[~2012-12-13 15:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 12:59 sound: usb-audio: full capture/playback/spdif support for Digidesign Mbox 2 Damien Zammit
2010-11-25 21:39 ` Daniel Mack
2010-11-29 13:03 ` Damien Zammit
2010-11-29 14:50 ` Takashi Iwai
2010-11-30 11:09 ` Damien Zammit
2010-11-30 15:26 ` Clemens Ladisch
2010-12-14 9:57 ` Damien Zammit
2010-12-27 14:50 ` Damien Zammit
2012-12-13 6:21 ` Damien Zammit
2012-12-13 7:01 ` Takashi Iwai
2012-12-13 13:09 ` Damien Zammit
2012-12-13 13:18 ` Takashi Iwai
2012-12-13 13:27 ` Takashi Iwai
2012-12-13 14:20 ` Damien Zammit
2012-12-13 14:59 ` Takashi Iwai
2012-12-13 15:29 ` Clemens Ladisch [this message]
2012-12-16 10:49 ` [PATCH] " Damien Zammit
2012-12-16 11:06 ` Damien Zammit
2012-12-17 10:25 ` Takashi Iwai
2012-12-18 12:09 ` Damien Zammit
2012-12-18 13:08 ` Takashi Iwai
2012-12-19 10:30 ` Takashi Iwai
2012-12-19 10:37 ` Damien Zammit
2012-12-22 23:38 ` Damien Zammit
2012-12-23 0:31 ` Damien Zammit
2012-12-23 2:18 ` Damien Zammit
2012-12-23 3:36 ` Damien Zammit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C9F45F.3010806@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=damien.zammit@gmail.com \
--cc=tiwai@suse.de \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.