From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjCnt-0003ui-4l for qemu-devel@nongnu.org; Thu, 13 Dec 2012 12:42:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjCnn-0000ED-7p for qemu-devel@nongnu.org; Thu, 13 Dec 2012 12:42:37 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38436 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjCnn-0000E0-1T for qemu-devel@nongnu.org; Thu, 13 Dec 2012 12:42:31 -0500 Message-ID: <50CA1383.6080906@suse.de> Date: Thu, 13 Dec 2012 18:42:27 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1355419527-7818-1-git-send-email-lmr@redhat.com> <1355419527-7818-2-git-send-email-lmr@redhat.com> In-Reply-To: <1355419527-7818-2-git-send-email-lmr@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] hw: add isa-debug-exit device v5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lucas Meneghel Rodrigues Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org, Gerd Hoffmann Am 13.12.2012 18:25, schrieb Lucas Meneghel Rodrigues: > From: Gerd Hoffmann >=20 > When present it makes qemu exit on any write. > Mapped to port 0x501 by default. >=20 > Without this patch Anthony doesn't allow me to > remove the bochs bios debug ports because his > test suite uses this. >=20 > Changes from v4: > * Fixed rebase mistake... again. >=20 > Changes from v3: > * Added a short description > * Added a copyright notice > * Added Signed-off-by line to the commit > message > * Made the GPL license header to say > 'or any later version', to simplify > things and be more in line with other > qemu source files > * Turned TypeInfo into static const >=20 > Changes from v2: > * Fixed rebase mistake >=20 > Changes from v1: > * Add access_size property to the device, > needed for kvm-unit-tests. >=20 > Signed-off-by: Gerd Hoffmann > Signed-off-by: Lucas Meneghel Rodrigues Thanks, Reviewed-by: Andreas F=E4rber The change log is getting large and should be dropped from the commit message when applying (usually goes under --- or in cover letter). Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg