From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>, Joe Perches <joe@perches.com>,
"Luck, Tony" <tony.luck@intel.com>,
Jiri Kosina <trivial@kernel.org>, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"user-mode-linux-devel@lists.sourceforge.net"
<user-mode-linux-devel@lists.sourceforge.net>,
"user-mode-linux-user@lists.sourceforge.net"
<user-mode-linux-user@lists.sourceforge.net>
Subject: Re: [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR
Date: Thu, 13 Dec 2012 10:42:28 -0800 [thread overview]
Message-ID: <50CA2194.40103@zytor.com> (raw)
In-Reply-To: <20121213183659.GC31485@liondog.tnic>
On 12/13/2012 10:37 AM, Borislav Petkov wrote:
>>
>> If appropriate, the code could be changed to
>>
>> (void *)(unsigned long)m->ip
>
> Can we explicitly cast it to what it is so that we can be explicit as to
> what we're casting it? IOW:
>
> (void *)(__u64)m->ip;
>
> Does that even work on 32bit?
>
> Also, does the compiler bitch about this useless cast when building with
> W=123?
>
Uh... no.
The point is that (void *)(unsigned long) casts it to an integer of
pointer size -- in userspace you would to (void *)(size_t) or (void
*)(uintptr_t) -- so that the compiler knows "I meant to do that."
-hpa
next prev parent reply other threads:[~2012-12-13 18:42 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 18:18 [Cluster-devel] [TRIVIAL PATCH 00/26] treewide: Add and use vsprintf extension %pSR Joe Perches
2012-12-12 18:18 ` Joe Perches
2012-12-12 18:18 ` Joe Perches
2012-12-12 18:18 ` Joe Perches
2012-12-12 18:18 ` Joe Perches
2012-12-12 18:18 ` Joe Perches
2012-12-12 18:18 ` Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 01/26] vsprintf: Add extension %pSR - print_symbol replacement Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 02/26] alpha: Convert print_symbol to %pSR Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 03/26] arm: " Joe Perches
2012-12-12 18:18 ` Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 04/26] arm64: " Joe Perches
2012-12-12 18:18 ` Joe Perches
2012-12-13 18:03 ` Catalin Marinas
2012-12-13 18:03 ` Catalin Marinas
2012-12-12 18:18 ` [TRIVIAL PATCH 05/26] avr32: " Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 06/26] c6x: " Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 07/26] ia64: " Joe Perches
2012-12-12 18:18 ` Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 08/26] m32r: " Joe Perches
2012-12-13 3:06 ` Hirokazu Takata
2013-04-29 13:21 ` Jiri Kosina
2013-04-30 12:56 ` Joe Perches
2013-04-30 21:11 ` Jiri Kosina
2012-12-12 18:18 ` [TRIVIAL PATCH 09/26] mn10300: " Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 10/26] openrisc: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 11/26] powerpc: " Joe Perches
2012-12-12 18:19 ` Joe Perches
2012-12-13 11:58 ` Arnd Bergmann
2012-12-13 11:58 ` Arnd Bergmann
2013-01-10 5:48 ` Benjamin Herrenschmidt
2013-01-10 5:48 ` Benjamin Herrenschmidt
2013-01-10 17:00 ` Joe Perches
2013-01-10 17:00 ` Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 12/26] s390: " Joe Perches
2012-12-13 1:22 ` Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 13/26] sh: " Joe Perches
2012-12-12 18:19 ` Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 14/26] um: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 15/26] unicore32: " Joe Perches
[not found] ` <001d01cdd8cd$371dfd60$a559f820$@mprc.pku.edu.cn>
2012-12-13 1:21 ` 答复: " Joe Perches
2012-12-13 2:00 ` Chen Gang
2012-12-13 2:26 ` Joe Perches
[not found] ` <19e6ea369e4455fc447c48f72bd433921bd0a703.1355335228.git.joe@perches.c om>
2012-12-13 5:05 ` guanxuetao
2012-12-12 18:19 ` [TRIVIAL PATCH 16/26] x86: " Joe Perches
2012-12-12 21:09 ` Borislav Petkov
2012-12-12 21:30 ` Joe Perches
2012-12-12 21:48 ` Borislav Petkov
2012-12-12 21:49 ` Luck, Tony
2012-12-12 22:23 ` Joe Perches
2012-12-12 22:45 ` Borislav Petkov
2012-12-13 18:23 ` Joe Perches
2012-12-13 18:23 ` Joe Perches
2012-12-13 18:37 ` Borislav Petkov
2012-12-13 18:37 ` Borislav Petkov
2012-12-13 18:42 ` H. Peter Anvin [this message]
2012-12-13 19:05 ` Borislav Petkov
2012-12-13 21:35 ` H. Peter Anvin
2012-12-13 18:57 ` Joe Perches
2012-12-13 18:57 ` Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 17/26] xtensa: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 18/26] drivers: base: " Joe Perches
2012-12-12 18:19 ` [Cluster-devel] [TRIVIAL PATCH 19/26] gfs2: " Joe Perches
2012-12-12 18:19 ` Joe Perches
2012-12-13 10:57 ` [Cluster-devel] " Steven Whitehouse
2012-12-13 10:57 ` Steven Whitehouse
2013-04-29 13:23 ` [Cluster-devel] " Jiri Kosina
2013-04-29 13:23 ` Jiri Kosina
2012-12-12 18:19 ` [TRIVIAL PATCH 20/26] sysfs: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 21/26] irq: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 22/26] smp_processor_id: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 23/26] mm: " Joe Perches
2012-12-12 18:19 ` Joe Perches
2012-12-12 20:08 ` Christoph Lameter
2012-12-12 20:08 ` Christoph Lameter
2013-04-29 13:24 ` Jiri Kosina
2013-04-29 13:24 ` Jiri Kosina
2012-12-12 18:19 ` [TRIVIAL PATCH 24/26] xtensa: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 25/26] x86: head_64.S: Use vsprintf extension %pSR not print_symbol Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 26/26] kallsyms: Remove print_symbol Joe Perches
2012-12-12 19:30 ` [TRIVIAL PATCH V2 24/26] Documentation: Convert print_symbol to %pSR Joe Perches
2012-12-13 1:43 ` [TRIVIAL PATCH V2 12/26] s390: " Joe Perches
2012-12-13 19:13 ` [TRIVIAL PATCH V2 16/26] x86: " Joe Perches
2013-01-08 5:52 ` [TRIVIAL PATCH 00/26] treewide: Add and use vsprintf extension %pSR Joe Perches
2013-01-08 20:33 ` Jiri Kosina
2013-02-20 6:00 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CA2194.40103@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=jdike@addtoit.com \
--cc=joe@perches.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=trivial@kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.