All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Add a new work-queue for destructing stations?
Date: Thu, 13 Dec 2012 11:00:01 -0800	[thread overview]
Message-ID: <50CA25B1.3080901@candelatech.com> (raw)
In-Reply-To: <1355424835.9463.18.camel@jlt4.sipsolutions.net>

On 12/13/2012 10:53 AM, Johannes Berg wrote:
> On Thu, 2012-12-13 at 19:49 +0100, Johannes Berg wrote:
>
>>>> Well the concern there is that we expose the workqueue to the driver,
>>>> and it might even put sdata-referencing work items on it and expect them
>>>> to be flushed out before stop_interface() is called?
>
> Wait actually, that isn't a concern. The flush_workqueue() was new in
> commit b22cfcfca, before that drivers couldn't rely on it. It seems very
> unlikely that in the meantime drivers have come to rely on it and we
> didn't document this, so ... with the proposed change to sta_free_wk we
> should be fine.

We still need to cancel the other mac80211 work items though, right?

I didn't understand your proposal for the sta_free_wk changes,
but I can at least work on tracking down the mac80211 work items
if that helps...

>
> johannes
>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2012-12-13 19:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-13 17:46 Add a new work-queue for destructing stations? Ben Greear
2012-12-13 17:59 ` Johannes Berg
2012-12-13 18:19   ` Ben Greear
2012-12-13 18:24     ` Johannes Berg
2012-12-13 18:27       ` Johannes Berg
2012-12-13 18:36         ` Johannes Berg
2012-12-13 18:30       ` Ben Greear
2012-12-13 18:37         ` Johannes Berg
2012-12-13 18:39           ` Ben Greear
2012-12-13 18:41             ` Johannes Berg
2012-12-13 18:47               ` Ben Greear
2012-12-13 18:49                 ` Johannes Berg
2012-12-13 18:53                   ` Johannes Berg
2012-12-13 19:00                     ` Ben Greear [this message]
2012-12-13 19:11                       ` Johannes Berg
2012-12-13 19:17                         ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50CA25B1.3080901@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.