From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jianguo Wu Subject: Re: [PATCH v2 UPDATE] mm/hugetlb: create hugetlb cgroup file in hugetlb_init Date: Fri, 14 Dec 2012 09:38:19 +0800 Message-ID: <50CA830B.2050209@huawei.com> References: <50C94DE5.2040302@huawei.com> <20121213135656.GB27775@dhcp22.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121213135656.GB27775-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Michal Hocko Cc: "Aneesh Kumar K.V" , tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Li Zefan , Andrew Morton , KAMEZAWA Hiroyuki , dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Liujiang , Jiang Liu , qiuxishi , Hanjun Guo , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 2012/12/13 21:56, Michal Hocko wrote: > On Thu 13-12-12 11:39:17, Jianguo Wu wrote: >> Build kernel with CONFIG_HUGETLBFS=y,CONFIG_HUGETLB_PAGE=y >> and CONFIG_CGROUP_HUGETLB=y, then specify hugepagesz=xx boot option, >> system will boot fail. >> >> This failure is caused by following code path: >> setup_hugepagesz >> hugetlb_add_hstate >> hugetlb_cgroup_file_init >> cgroup_add_cftypes >> kzalloc <--slab is *not available* yet >> >> For this path, slab is not available yet, so memory allocated will be >> failed, and cause WARN_ON() in hugetlb_cgroup_file_init(). >> >> So I move hugetlb_cgroup_file_init() into hugetlb_init(). >> >> Changelog: >> do code refactor as suggesting by Aneesh >> add Reviewed-by and Acked-by >> >> Signed-off-by: Jianguo Wu >> Signed-off-by: Jiang Liu >> Reviewed-by: Aneesh Kumar K.V >> Acked-by: Michal Hocko > > Any reason to not add Cc: stable as I suggested earlier? Hi Michal, Sorry for forgot that. Andrew has added Cc: stable when added to -mm tree. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx204.postini.com [74.125.245.204]) by kanga.kvack.org (Postfix) with SMTP id 2D8F56B0044 for ; Thu, 13 Dec 2012 20:38:58 -0500 (EST) Message-ID: <50CA830B.2050209@huawei.com> Date: Fri, 14 Dec 2012 09:38:19 +0800 From: Jianguo Wu MIME-Version: 1.0 Subject: Re: [PATCH v2 UPDATE] mm/hugetlb: create hugetlb cgroup file in hugetlb_init References: <50C94DE5.2040302@huawei.com> <20121213135656.GB27775@dhcp22.suse.cz> In-Reply-To: <20121213135656.GB27775@dhcp22.suse.cz> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: "Aneesh Kumar K.V" , tj@kernel.org, Li Zefan , Andrew Morton , KAMEZAWA Hiroyuki , dhillf@gmail.com, Liujiang , Jiang Liu , qiuxishi , Hanjun Guo , linux-kernel@vger.kernel.org, linux-mm@kvack.org, containers@lists.linux-foundation.org, cgroups@vger.kernel.org On 2012/12/13 21:56, Michal Hocko wrote: > On Thu 13-12-12 11:39:17, Jianguo Wu wrote: >> Build kernel with CONFIG_HUGETLBFS=y,CONFIG_HUGETLB_PAGE=y >> and CONFIG_CGROUP_HUGETLB=y, then specify hugepagesz=xx boot option, >> system will boot fail. >> >> This failure is caused by following code path: >> setup_hugepagesz >> hugetlb_add_hstate >> hugetlb_cgroup_file_init >> cgroup_add_cftypes >> kzalloc <--slab is *not available* yet >> >> For this path, slab is not available yet, so memory allocated will be >> failed, and cause WARN_ON() in hugetlb_cgroup_file_init(). >> >> So I move hugetlb_cgroup_file_init() into hugetlb_init(). >> >> Changelog: >> do code refactor as suggesting by Aneesh >> add Reviewed-by and Acked-by >> >> Signed-off-by: Jianguo Wu >> Signed-off-by: Jiang Liu >> Reviewed-by: Aneesh Kumar K.V >> Acked-by: Michal Hocko > > Any reason to not add Cc: stable as I suggested earlier? Hi Michal, Sorry for forgot that. Andrew has added Cc: stable when added to -mm tree. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755804Ab2LNBi4 (ORCPT ); Thu, 13 Dec 2012 20:38:56 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:32542 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753603Ab2LNBiz (ORCPT ); Thu, 13 Dec 2012 20:38:55 -0500 Message-ID: <50CA830B.2050209@huawei.com> Date: Fri, 14 Dec 2012 09:38:19 +0800 From: Jianguo Wu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Michal Hocko CC: "Aneesh Kumar K.V" , , Li Zefan , Andrew Morton , KAMEZAWA Hiroyuki , , Liujiang , Jiang Liu , qiuxishi , Hanjun Guo , , , , Subject: Re: [PATCH v2 UPDATE] mm/hugetlb: create hugetlb cgroup file in hugetlb_init References: <50C94DE5.2040302@huawei.com> <20121213135656.GB27775@dhcp22.suse.cz> In-Reply-To: <20121213135656.GB27775@dhcp22.suse.cz> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.74.216] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2012/12/13 21:56, Michal Hocko wrote: > On Thu 13-12-12 11:39:17, Jianguo Wu wrote: >> Build kernel with CONFIG_HUGETLBFS=y,CONFIG_HUGETLB_PAGE=y >> and CONFIG_CGROUP_HUGETLB=y, then specify hugepagesz=xx boot option, >> system will boot fail. >> >> This failure is caused by following code path: >> setup_hugepagesz >> hugetlb_add_hstate >> hugetlb_cgroup_file_init >> cgroup_add_cftypes >> kzalloc <--slab is *not available* yet >> >> For this path, slab is not available yet, so memory allocated will be >> failed, and cause WARN_ON() in hugetlb_cgroup_file_init(). >> >> So I move hugetlb_cgroup_file_init() into hugetlb_init(). >> >> Changelog: >> do code refactor as suggesting by Aneesh >> add Reviewed-by and Acked-by >> >> Signed-off-by: Jianguo Wu >> Signed-off-by: Jiang Liu >> Reviewed-by: Aneesh Kumar K.V >> Acked-by: Michal Hocko > > Any reason to not add Cc: stable as I suggested earlier? Hi Michal, Sorry for forgot that. Andrew has added Cc: stable when added to -mm tree.