From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version
Date: Fri, 14 Dec 2012 08:54:08 +0100 [thread overview]
Message-ID: <50CADB20.9010308@redhat.com> (raw)
In-Reply-To: <79C05D8D-072A-40C9-8CEB-2C7350C2A8E7@suse.de>
Hi,
>> If you send me a fix for 6e72719e721a40fe1224701ca10edc1caf0cd708
>> I'll go revert 288fa40736e6eb63132d01aa6dc21ee831b796ae
>
> 6e72719 is perfectly sane, because it brings consistency into the
> file. Now both users of PIXMAN_TYPE_BGRA are guarded by the same
> #ifdef.
Both users? Hello? Its two *different* types: PIXMAN_TYPE_RGBA and
PIXMAN_TYPE_BGRA. And, yes, they have been added in different versions.
So guarding them with the *same* #ifdef is wrong.
> #ifdef PIXMAN_TYPE_BGRA
It's a enum, not a #define, so this isn't going to fly.
cheers,
Gerd
next prev parent reply other threads:[~2012-12-14 7:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 12:48 [Qemu-devel] [PATCH 0/2] pixman: two little fixes Gerd Hoffmann
2012-12-10 12:48 ` [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version Gerd Hoffmann
2012-12-13 14:31 ` Alexander Graf
2012-12-13 14:48 ` Gerd Hoffmann
2012-12-13 14:50 ` Alexander Graf
2012-12-13 15:30 ` Gerd Hoffmann
2012-12-13 16:10 ` Alexander Graf
2012-12-14 7:54 ` Gerd Hoffmann [this message]
2012-12-14 9:57 ` Alexander Graf
2012-12-13 14:56 ` Alexander Graf
2012-12-10 12:48 ` [Qemu-devel] [PATCH 2/2] pixman: update internal copy to pixman-0.28.2 Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CADB20.9010308@redhat.com \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.