From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH] Disable caml-stubdom by default
Date: Fri, 14 Dec 2012 16:34:40 +0100
Message-ID: <50CB4710.8010502@citrix.com>
References: <1355412718-4610-1-git-send-email-matthew.fioravante@jhuapl.edu>,
	<CAFLBxZZQ9Nw09L01ekS4k0W92gZ27F+5R82192HgO_tWEp02Ug@mail.gmail.com>
	<068F06DC4D106941B297C0C5F9F446EA48BDDDC20D@aplesstripe.dom1.jhuapl.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <068F06DC4D106941B297C0C5F9F446EA48BDDDC20D@aplesstripe.dom1.jhuapl.edu>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Fioravante, Matthew E." <Matthew.Fioravante@jhuapl.edu>
Cc: George Dunlap <dunlapg@umich.edu>, Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 14/12/12 15:33, Fioravante, Matthew E. wrote:
> Caml was disabled in the original stubdom default build targets. I should not have enabled it in my original stubdom autoconf patch.

Does caml-stubdom require something else apart from caml itself? If not
I think it should be enabled by default if caml is detected (like we do
for the caml xenstore in the tools).

> ________________________________________
> From: dunlapg@gmail.com [dunlapg@gmail.com] On Behalf Of George Dunlap [dunlapg@umich.edu]
> Sent: Thursday, December 13, 2012 12:47 PM
> To: Fioravante, Matthew E.
> Cc: Ian Campbell; xen-devel@lists.xen.org
> Subject: Re: [Xen-devel] [PATCH] Disable caml-stubdom by default
> 
> Is there a rationale for this?  If so, it should probably be in the commit message.
> 
>  -George
> 
> 
> On Thu, Dec 13, 2012 at 3:31 PM, Matthew Fioravante <matthew.fioravante@jhuapl.edu<mailto:matthew.fioravante@jhuapl.edu>> wrote:
> Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu<mailto:matthew.fioravante@jhuapl.edu>>
> ---
>  stubdom/configure.ac<http://configure.ac> |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/stubdom/configure.ac<http://configure.ac> b/stubdom/configure.ac<http://configure.ac>
> index db44d4a..384a94a 100644
> --- a/stubdom/configure.ac<http://configure.ac>
> +++ b/stubdom/configure.ac<http://configure.ac>
> @@ -18,7 +18,7 @@ m4_include([../m4/depends.m4])
>  # Enable/disable stub domains
>  AX_STUBDOM_DEFAULT_ENABLE([ioemu-stubdom], [ioemu])
>  AX_STUBDOM_DEFAULT_DISABLE([c-stubdom], [c])
> -AX_STUBDOM_DEFAULT_ENABLE([caml-stubdom], [caml])
> +AX_STUBDOM_DEFAULT_DISABLE([caml-stubdom], [caml])
>  AX_STUBDOM_DEFAULT_ENABLE([pv-grub], [grub])
>  AX_STUBDOM_DEFAULT_ENABLE([xenstore-stubdom], [xenstore])
>  AX_STUBDOM_CONDITIONAL([vtpm-stubdom], [vtpm])
> --
> 1.7.10.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org<mailto:Xen-devel@lists.xen.org>
> http://lists.xen.org/xen-devel
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>