All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: David Dillow <dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org>
Cc: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH v2 1/2] IB/srp: Track connection state properly
Date: Fri, 14 Dec 2012 16:34:43 +0100	[thread overview]
Message-ID: <50CB4713.4080909@acm.org> (raw)
In-Reply-To: <50CB46A4.4050300-HInyCGIudOg@public.gmane.org>

The connection state must be initialized before srp_connect_target()
is invoked. Drop the assignment in srp_add_target() since
scsi_host_alloc() zero-initializes the Scsi_Host structure anyway.
This patch makes ib_srp again report the first QP error.

Signed-off-by: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
Cc: David Dillow <dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org>
Cc: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
---
 drivers/infiniband/ulp/srp/ib_srp.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index d5088ce..94f76b9 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -1972,7 +1972,6 @@ static int srp_add_target(struct srp_host *host, struct srp_target_port *target)
 	spin_unlock(&host->target_lock);
 
 	target->state = SRP_TARGET_LIVE;
-	target->connected = false;
 
 	scsi_scan_target(&target->scsi_host->shost_gendev,
 			 0, target->scsi_id, SCAN_WILD_CARD, 0);
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2012-12-14 15:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-14 15:32 [PATCH v2] IB/SRP patches for kernel 3.8 Bart Van Assche
     [not found] ` <50CB46A4.4050300-HInyCGIudOg@public.gmane.org>
2012-12-14 15:34   ` Bart Van Assche [this message]
     [not found]     ` <50CB4713.4080909-HInyCGIudOg@public.gmane.org>
2012-12-14 15:48       ` [PATCH v2 1/2] IB/srp: Track connection state properly David Dillow
2012-12-14 15:38   ` [PATCH v2 2/2] IB/srp: Avoid endless SCSI error handling loop Bart Van Assche
     [not found]     ` <50CB47E7.2060308-HInyCGIudOg@public.gmane.org>
2012-12-14 15:55       ` David Dillow
     [not found]         ` <1355500552.18309.11.camel-zHLflQxYYDO4Hhoo1DtQwJ9G+ZOsUmrO@public.gmane.org>
2012-12-14 16:12           ` Bart Van Assche
     [not found]             ` <50CB4FEB.3080104-HInyCGIudOg@public.gmane.org>
2012-12-14 16:19               ` David Dillow
     [not found]                 ` <1355501996.18309.16.camel-zHLflQxYYDO4Hhoo1DtQwJ9G+ZOsUmrO@public.gmane.org>
2012-12-14 16:30                   ` Bart Van Assche
     [not found]                     ` <50CB5432.8040204-HInyCGIudOg@public.gmane.org>
2012-12-14 18:14                       ` Vu Pham
2012-12-19  4:09               ` David Dillow
     [not found]                 ` <1355890164.23969.0.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2012-12-19 14:15                   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50CB4713.4080909@acm.org \
    --to=bvanassche-hinycgiudog@public.gmane.org \
    --cc=dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.