From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54449)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TjvEl-0001qj-4E
	for qemu-devel@nongnu.org; Sat, 15 Dec 2012 12:09:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TjvEj-0005oq-P9
	for qemu-devel@nongnu.org; Sat, 15 Dec 2012 12:09:19 -0500
Received: from cantor2.suse.de ([195.135.220.15]:52793 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TjvEj-0005kB-JD
	for qemu-devel@nongnu.org; Sat, 15 Dec 2012 12:09:17 -0500
Message-ID: <50CCAE89.5040102@suse.de>
Date: Sat, 15 Dec 2012 18:08:25 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <20121214233957.GA19778@amt.cnet>
	<CAF3u54Cuede5oGLXHunzs9Qxt_fXLmqXO7EP6E+qbxzfNhMFfg@mail.gmail.com>
In-Reply-To: <CAF3u54Cuede5oGLXHunzs9Qxt_fXLmqXO7EP6E+qbxzfNhMFfg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Julien Grall <julien.grall@gmail.com>
Cc: Julien Grall <julien.grall@citrix.com>, Marcelo Tosatti <mtosatti@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Am 15.12.2012 14:45, schrieb Julien Grall:
> On Fri, Dec 14, 2012 at 11:39 PM, Marcelo Tosatti <mtosatti@redhat.com>=
 wrote:
>>
>>
>> The high byte of the ioport address is necessary to compute
>> the register address, see "82371AB PCI ISA IDE Xcelerator (PIIX4)"
>> document, eg:
>>
>> 4.2.1.1. DCOM=E2=80=94DMA Command Register (IO)
>> I/O Address: Channels 0=E2=80=933=E2=80=9408h; Channels 4=E2=80=937=E2=
=80=940D0h
>>
>=20
> I sent a patch on the mailing to resolve the problem yesterday
> (http://www.mail-archive.com/qemu-devel@nongnu.org/msg145242.html).
> Did it resolve your WinXp-32 installation? I just need to rework the co=
mment.
>=20
>>
>> Also the size of the region is wrong.
>=20
> I don't think the size of the region is wrong. For the second DMA
> controller, the ioports are 0xD0 - 0xDE for the control registers.
> So the size is 16 not 8. It's the same for the channel registers.

You did seem to change it in size, if you compare my review questions,
without you mentioning why in the patch.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg