Re: [PATCH v2 3/6] iio: dac: ad5504: Don't set error code to voltage_uv

[Jonathan Cameron <jic23@kernel.org>]

On 12/14/2012 12:06 PM, Axel Lin wrote:
> regulator_get_voltage() may return negative error code.
> Add error checking to avoid setting error code to voltage_uv.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Axel,

I would definitely have prefered a resend of the whole series rather than
just the ones you have fixed up.

I assumed Lars would have no objection to Acking these as well!

Anyhow 1,2,6 from v1 and 3,4,5 from v2 added to fixes-togreg branch of
iio.git.

Thanks for all these!

Jonathan

> ---
> v2: check if ret is negative value
>  drivers/iio/dac/ad5504.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c
> index 242bdc7..1e9a1f4 100644
> --- a/drivers/iio/dac/ad5504.c
> +++ b/drivers/iio/dac/ad5504.c
> @@ -296,7 +296,11 @@ static int __devinit ad5504_probe(struct spi_device *spi)
>  		if (ret)
>  			goto error_put_reg;
>  
> -		voltage_uv = regulator_get_voltage(reg);
> +		ret = regulator_get_voltage(reg);
> +		if (ret < 0)
> +			goto error_disable_reg;
> +
> +		voltage_uv = ret;
>  	}
>  
>  	spi_set_drvdata(spi, indio_dev);
>