All of lore.kernel.org
 help / color / mirror / Atom feed
From: Donghwa Lee <dh09.lee@samsung.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: exynos_mipi_dsi: Add missing mutex_unlock
Date: Mon, 17 Dec 2012 01:31:20 +0000	[thread overview]
Message-ID: <50CE75E8.1010102@samsung.com> (raw)
In-Reply-To: <000801cdd9d5$a9536a10$fbfa3e30$%choi@samsung.com>

  On Fri, Dec 14, 2012 at 17:33, Jonghwan Choi wrote:
> Add a mutex_unlock on the error path.
>
> Signed-off-by: Jonghwan Choi<jhbird.choi@samsung.com>
> ---
>   drivers/video/exynos/exynos_mipi_dsi_common.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/exynos/exynos_mipi_dsi_common.c
> b/drivers/video/exynos/exynos_mipi_dsi_common.c
> index 3cd29a4..bd7f4f2 100644
> --- a/drivers/video/exynos/exynos_mipi_dsi_common.c
> +++ b/drivers/video/exynos/exynos_mipi_dsi_common.c
> @@ -377,6 +377,7 @@ int exynos_mipi_dsi_rd_data(struct mipi_dsim_device
> *dsim, unsigned int data_id,
>   			"data id %x is not supported current DSI spec.\n",
>   			data_id);
>   
> +		mutex_unlock(&dsim->lock);
>   		return -EINVAL;
>   	}
>   
It looks good to me.

Acked-by: Donghwa Lee <dh09.lee@samsung.com>

Thank you,
Donghwa Lee

      reply	other threads:[~2012-12-17  1:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-14  8:33 [PATCH] video: exynos_mipi_dsi: Add missing mutex_unlock Jonghwan Choi
2012-12-17  1:31 ` Donghwa Lee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50CE75E8.1010102@samsung.com \
    --to=dh09.lee@samsung.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.