From: Vipin Kumar <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH resend 2/2] arm/boards: Define a new config option CONFIG_BOOT_PARAMS_P
Date: Mon, 17 Dec 2012 13:45:00 +0530 [thread overview]
Message-ID: <50CED484.1060501@st.com> (raw)
In-Reply-To: <20121207144733.0FDFE201621@gemini.denx.de>
On 12/7/2012 8:17 PM, Wolfgang Denk wrote:
> Dear Vipin Kumar,
>
> In message<50C1B9A6.1020106@st.com> you wrote:
>>
>> Can you please suggest what is the best way here. Wolfgang, Albert ?
>
> I don't like this patch at all. It introduces yet more
> architecture specific stuff to lib/board.c, while we actually should
> be working on coming up with a common version for all architectures.
>
> If you want to simplify code, then please not by making it worse in
> other places.
>
I agree, but this code adds an option to pass boot params pointer to
board descriptor.
Just two lines above the intended change, there is a mach_type
initialization based on the definition of CONFIG_MACH_TYPE. Moreover,
the lib/board.c exists in arch/arm as of today which means that it can
contain all the stuff common for arm boards
If I am right, the patch should also be OK
Vipin
> Best regards,
>
> Wolfgang Denk
>
next prev parent reply other threads:[~2012-12-17 8:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 9:29 [U-Boot] [PATCH resend 1/2] u-boot/spl: Add u-boot-spl.img to u-boot targets Vipin Kumar
2012-12-06 9:29 ` [U-Boot] [PATCH resend 2/2] arm/boards: Define a new config option CONFIG_BOOT_PARAMS_P Vipin Kumar
2012-12-06 9:44 ` Stefan Roese
2012-12-06 9:56 ` Vipin Kumar
2012-12-06 11:26 ` Stefan Roese
2012-12-07 9:40 ` Vipin Kumar
2012-12-07 14:47 ` Wolfgang Denk
2012-12-17 8:15 ` Vipin Kumar [this message]
2012-12-06 12:08 ` [U-Boot] [PATCH resend 1/2] u-boot/spl: Add u-boot-spl.img to u-boot targets Stefan Roese
2012-12-07 9:47 ` Vipin Kumar
2012-12-07 10:44 ` Stefan Roese
2012-12-07 11:55 ` Vipin Kumar
2012-12-07 11:59 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CED484.1060501@st.com \
--to=vipin.kumar@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.