From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Christian_K=F6nig?= <deathsimple@vodafone.de>
Subject: Re: [PATCH] drm/radeon: resume fence driver to last sync sequence
	on lockup
Date: Mon, 17 Dec 2012 10:11:23 +0100
Message-ID: <50CEE1BB.7090500@vodafone.de>
References: <1355506776-3213-1-git-send-email-j.glisse@gmail.com>
	<50CB8856.1080505@vodafone.de>
	<CAH3drwbbJMvLn-FkSpyVZWLwh857ceeGaVHPDv2e+=6A75Abtw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from outgoing.email.vodafone.de (outgoing.email.vodafone.de
	[139.7.28.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id 7E5A7E611D
	for <dri-devel@lists.freedesktop.org>;
	Mon, 17 Dec 2012 01:11:27 -0800 (PST)
In-Reply-To: <CAH3drwbbJMvLn-FkSpyVZWLwh857ceeGaVHPDv2e+=6A75Abtw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Jerome Glisse <j.glisse@gmail.com>
Cc: Jerome Glisse <jglisse@redhat.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 14.12.2012 21:33, Jerome Glisse wrote:
> On Fri, Dec 14, 2012 at 3:13 PM, Christian K=F6nig
> <deathsimple@vodafone.de> wrote:
>> On 14.12.2012 18:39, j.glisse@gmail.com wrote:
>>> From: Jerome Glisse <jglisse@redhat.com>
>>>
>>> After lockup we need to resume fence to last sync sequence and not
>>> last received sequence so that all thread waiting on command stream
>>> that lockedup resume. Otherwise GPU reset will be ineffective in most
>>> cases.
>> NAK. I changed this on purpose to get partial resets working, please don=
't
>> change it back.
>>
>> The IB test code should reset this to the last synced value anyway, if it
>> doesn't work then there is something wrong there.
>>
>> Christian.
> There is something wrong ....

What symptoms? What exactly is going wrong?

Thinking about it the sequence probably won't get reseted when we =

encounter a unrecoverable GPU lockup. And even when the partial GPU =

reset fails it might be a good idea to reset the fence sequence like =

this....

Ok, you're right there is something wrong. Going to write a patch for =

this...

Cheers,
Christian.