All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Metcalf <cmetcalf@tilera.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] arch/tile: implement user_regset interface on tilegx
Date: Mon, 17 Dec 2012 12:06:22 -0500	[thread overview]
Message-ID: <50CF510E.6050406@tilera.com> (raw)
In-Reply-To: <1355546091-32537-1-git-send-email-simon.marchi@polymtl.ca>

On 12/14/2012 11:34 PM, Simon Marchi wrote:
> This is an implementation of user_regset for the tilegx architecture. It
> reuses the basic blocks that were already there.

Thanks, Simon!  A couple of comments:

I encourage you to respin this for tilepro as well as tilegx, since it's going to be trivial to make it happen.  Just take away all yours ifdefs, and use #include <arch/chip.h> and CHIP_ARCH_NAME instead of the string "tilegx".  It's worth it just to avoid the ifdefs in the code :-)

I think with this support added, we have all the prerequisites to add "select HAVE_ARCH_TRACEHOOK" under "config TILE" in arch/tile/Kconfig, so we might as well do that too.  That will enable PTRACE_GETREGSET and PTRACE_SETREGSET, as well as /proc/PID/syscall, so why not?

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com


  parent reply	other threads:[~2012-12-17 17:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-15  4:34 [PATCH 1/3] arch/tile: implement user_regset interface on tilegx Simon Marchi
2012-12-15  4:34 ` [PATCH 2/3] arch/tile: implement arch_ptrace using user_regset " Simon Marchi
2012-12-15  4:34 ` [PATCH 3/3] arch/tile: set CORE_DUMP_USE_REGSET " Simon Marchi
2012-12-17 17:06 ` Chris Metcalf [this message]
2012-12-17 22:07   ` [PATCH 1/3] arch/tile: implement user_regset interface " Simon Marchi
2012-12-17 22:59     ` Chris Metcalf
2012-12-18  1:05       ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50CF510E.6050406@tilera.com \
    --to=cmetcalf@tilera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.