All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@elte.hu>,
	Michael Kerrisk <mtk.manpages@gmail.com>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	Matt Fleming <matt.fleming@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Dave Jones <davej@redhat.com>,
	David Howells <dhowells@redhat.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Markus Trippelsdorf <markus@trippelsdorf.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] x86/uapi for 3.8
Date: Mon, 17 Dec 2012 09:15:52 -0800	[thread overview]
Message-ID: <50CF5348.2000606@linux.intel.com> (raw)
In-Reply-To: <50CF5E8602000078000B0D2C@nat28.tlf.novell.com>

On 12/17/2012 09:03 AM, Jan Beulich wrote:
>>>> On 17.12.12 at 17:39, "H. Peter Anvin" <hpa@linux.intel.com> wrote:
>> Right, I think you nailed this one.  This patch copies PTEs from the
>> kernel PTEs and thus they will have the global bit set.  It obviously
>> makes no sense to *copy* PTEs from the kernel and yet leaving the global
>> bit set, which means there are two ways of fixing it: either sharing
>> page tables and use the cr4.pge off/on trick that Jan mentioned -- this
>> would also be my preference -- and the other is to copy the PTEs but
>> strip the global bit, which has the advantage that the actual kernel
>> mappings will survive.
> 
> PTE copying is only one half of it. I think additionally L4 entries
> get copied for the 1:1 mapping, and you can't strip the global
> bits there without allocating separate page tables.
> 

The point right now is that it *does* allocate separate page tables, but
doesn't take advantage of it.  What I say is I think we should take the
flush for the advantage of sharing page tables.  If we are allocating
new page tables then we should of course make them non-global.

Do we know how often this gets called?  I presume the most common case
is when we have an EFI RTC?  Unless there is a use case where this
happens a lot sharing seems much easier...

	-hpa



  reply	other threads:[~2012-12-17 17:16 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-12 22:11 [GIT PULL] x86/uapi for 3.8 H. Peter Anvin
2012-12-12 23:48 ` David Howells
2012-12-14 18:25   ` Linus Torvalds
2012-12-14 23:45     ` David Howells
2012-12-15  1:16       ` Linus Torvalds
2012-12-15  1:41         ` Linus Torvalds
2012-12-15  1:47           ` Linus Torvalds
2012-12-15 16:33             ` Markus Trippelsdorf
2012-12-15 16:35               ` Markus Trippelsdorf
2012-12-16 12:43                 ` Matt Fleming
2012-12-16 13:25                   ` Markus Trippelsdorf
2012-12-16 14:54                     ` Matt Fleming
2012-12-16 20:12                       ` Linus Torvalds
2012-12-16 22:07                         ` Linus Torvalds
2012-12-16 22:25                           ` H. Peter Anvin
2012-12-16 22:40                           ` Matt Fleming
2012-12-16 22:52                             ` Linus Torvalds
2012-12-16 23:49                           ` Markus Trippelsdorf
2012-12-15 18:35               ` Linus Torvalds
2012-12-15 19:41                 ` H. Peter Anvin
2012-12-15 19:58                   ` Linus Torvalds
2012-12-15 20:06                     ` Markus Trippelsdorf
2012-12-15 21:04                     ` Markus Trippelsdorf
2012-12-15 21:06                       ` Linus Torvalds
2012-12-15 21:36                         ` H. Peter Anvin
2012-12-15 22:05                         ` Yinghai Lu
2012-12-15 23:37                           ` Linus Torvalds
2012-12-15 23:46                             ` H. Peter Anvin
2012-12-16 12:46                             ` Matt Fleming
2012-12-15 21:37                     ` Dave Jones
2012-12-15 23:47                       ` H. Peter Anvin
2012-12-17  9:04                 ` Jan Beulich
2012-12-17 15:44                   ` Linus Torvalds
2012-12-17 16:00                     ` Jan Beulich
2012-12-17 16:39                       ` H. Peter Anvin
2012-12-17 17:03                         ` Jan Beulich
2012-12-17 17:15                           ` H. Peter Anvin [this message]
2012-12-18  8:02                             ` Jan Beulich
2012-12-15  4:25         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50CF5348.2000606@linux.intel.com \
    --to=hpa@linux.intel.com \
    --cc=JBeulich@suse.com \
    --cc=arnd@arndb.de \
    --cc=davej@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=matt.fleming@intel.com \
    --cc=mingo@elte.hu \
    --cc=mtk.manpages@gmail.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.